react-input: Updated to use new shared tokens #22836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f7edb4c:
|
📊 Bundle size report🤖 This report was generated against d325a31bcd5d144e2a40ee4bf085e8ef6b3f5d73 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d325a31bcd5d144e2a40ee4bf085e8ef6b3f5d73 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 933 | 947 | 5000 | |
| Button | mount | 564 | 548 | 5000 | |
| FluentProvider | mount | 1838 | 1790 | 5000 | |
| FluentProviderWithTheme | mount | 254 | 249 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 247 | 243 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 283 | 299 | 10 | |
| MakeStyles | mount | 1607 | 1579 | 50000 |
spmonahan
approved these changes
May 4, 2022
| @@ -15,32 +15,9 @@ export const inputClassNames: SlotClassNames<InputSlots> = { | |||
| }; | |||
|
|
|||
| // TODO(sharing) use theme values once available | |||
There was a problem hiding this comment.
Can we remove this comment now?
There was a problem hiding this comment.
There is the leftover contentSizes[400] so I left that comment there.
packages/react-components/react-input/src/components/Input/useInputStyles.ts
Outdated
Show resolved
Hide resolved
…InputStyles.ts Co-authored-by: Sean Monahan <[email protected]>
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* Updated to use new theme tokens * yarn change * Update packages/react-components/react-input/src/components/Input/useInputStyles.ts Co-authored-by: Sean Monahan <[email protected]> Co-authored-by: Sean Monahan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
Updates #22231