Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8 snap: LineChart cherry-picks #16634

Merged
merged 3 commits into from
Jan 27, 2021
Merged

v8 snap: LineChart cherry-picks #16634

merged 3 commits into from
Jan 27, 2021

Conversation

kubkon
Copy link
Contributor

@kubkon kubkon commented Jan 26, 2021 •
edited
Loading

Each commit is a single cherry-pick from v7 branch, and each deals with some aspect of LineChart component:

@kubkon kubkon requested a review from Raghurk as a code owner January 26, 2021 11:49
Jakub Konka and others added 2 commits January 26, 2021 12:55
Line chart: Last circle callout issue fixed (microsoft#16556)
8155257 
* Line Chart: X axis callout for last circle issue resolved. Updated xAxisCalloutData for last circle

* Change files

* update email in change file

Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <[email protected]>
Charting: Tooltip disappear on escape click issue fixed in line chart (…
75957da 
…microsoft#16491)

* Tooltip disappear after click on escape issue fixed

* Change files

* email updated in change log file

* updated deprecated property

* updated code to trigger build

Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <[email protected]>
@kubkon kubkon changed the title v8 snap: cherry-pick of #16556 v8 snap: LineChart cherry-picks Jan 26, 2021
@kubkon kubkon marked this pull request as draft January 26, 2021 11:59
@kubkon kubkon marked this pull request as ready for review January 26, 2021 12:07
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b32bb9a:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jan 26, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 21f0fdb42254e758cb935494c5a8721337fa8e02 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 944 902 5000
BaseButtonCompat mount 1020 1014 5000
Breadcrumb mount 44819 45176 5000
Checkbox mount 1655 1639 5000
CheckboxBase mount 1379 1357 5000
ChoiceGroup mount 5057 5168 5000
ComboBox mount 1025 1116 1000
CommandBar mount 10570 10437 1000
ContextualMenu mount 6378 6341 1000
DefaultButtonCompat mount 1237 1236 5000
DetailsRow mount 3886 3935 5000
DetailsRowFast mount 3882 3846 5000
DetailsRowNoStyles mount 3686 3615 5000
Dialog mount 1575 1606 1000
DocumentCardTitle mount 1846 1878 1000
Dropdown mount 3593 3579 5000
FocusTrapZone mount 1901 1897 5000
FocusZone mount 1906 1901 5000
IconButtonCompat mount 1961 1967 5000
Label mount 369 354 5000
Layer mount 1905 1918 5000
Link mount 509 503 5000
MakeStyles mount 2040 2178 50000
MenuButtonCompat mount 1562 1556 5000
MessageBar mount 2095 2175 5000
Nav mount 3550 3513 1000
OverflowSet mount 1088 1124 5000
Panel mount 1569 1498 1000
Persona mount 910 878 1000
Pivot mount 1488 1493 1000
PrimaryButtonCompat mount 1383 1329 5000
Rating mount 8152 8309 5000
SearchBox mount 1451 1448 5000
Shimmer mount 2775 2802 5000
Slider mount 1999 1977 5000
SpinButton mount 5318 5352 5000
Spinner mount 446 453 5000
SplitButtonCompat mount 3435 3453 5000
Stack mount 572 570 5000
StackWithIntrinsicChildren mount 1747 1680 5000
StackWithTextChildren mount 5080 5005 5000
SwatchColorPicker mount 11097 11038 5000
Tabs mount 1444 1481 1000
TagPicker mount 2972 3031 5000
TeachingBubble mount 12177 12111 5000
Text mount 444 441 5000
TextField mount 1484 1490 5000
ThemeProvider mount 2226 2198 5000
ThemeProvider virtual-rerender 680 665 5000
Toggle mount 857 854 5000
button mount 748 724 5000
buttonNative mount 112 127 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.54 0.35:1 2000 389
🦄 Button.Fluent 0.14 0.22 0.64:1 5000 676
🔧 Checkbox.Fluent 0.69 0.39 1.77:1 1000 692
🎯 Dialog.Fluent 0.18 0.25 0.72:1 5000 920
🔧 Dropdown.Fluent 3.21 0.44 7.3:1 1000 3212
🔧 Icon.Fluent 0.15 0.07 2.14:1 5000 755
🦄 Image.Fluent 0.09 0.14 0.64:1 5000 469
🔧 Slider.Fluent 1.7 0.47 3.62:1 1000 1704
🔧 Text.Fluent 0.08 0.04 2:1 5000 414
🦄 Tooltip.Fluent 0.12 0.93 0.13:1 5000 597

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 206 183 1.13:1
DividerMinimalPerf.default 448 416 1.08:1
HeaderSlotsPerf.default 964 890 1.08:1
Image.Fluent 469 434 1.08:1
BoxMinimalPerf.default 446 418 1.07:1
LoaderMinimalPerf.default 813 762 1.07:1
RadioGroupMinimalPerf.default 537 501 1.07:1
AccordionMinimalPerf.default 196 185 1.06:1
AnimationMinimalPerf.default 465 440 1.06:1
SegmentMinimalPerf.default 436 413 1.06:1
ButtonMinimalPerf.default 219 209 1.05:1
SkeletonMinimalPerf.default 430 410 1.05:1
Avatar.Fluent 389 369 1.05:1
AttachmentSlotsPerf.default 1334 1283 1.04:1
FormMinimalPerf.default 517 496 1.04:1
ListCommonPerf.default 735 710 1.04:1
ListMinimalPerf.default 572 549 1.04:1
TableMinimalPerf.default 464 447 1.04:1
Text.Fluent 414 398 1.04:1
CardMinimalPerf.default 650 632 1.03:1
RefMinimalPerf.default 250 243 1.03:1
CarouselMinimalPerf.default 547 535 1.02:1
FlexMinimalPerf.default 357 350 1.02:1
InputMinimalPerf.default 1438 1408 1.02:1
ProviderMergeThemesPerf.default 1723 1684 1.02:1
SplitButtonMinimalPerf.default 4128 4054 1.02:1
TableManyItemsPerf.default 2333 2294 1.02:1
TextMinimalPerf.default 421 412 1.02:1
TooltipMinimalPerf.default 893 876 1.02:1
Checkbox.Fluent 692 680 1.02:1
Dialog.Fluent 920 906 1.02:1
Slider.Fluent 1704 1675 1.02:1
AvatarMinimalPerf.default 234 232 1.01:1
ChatDuplicateMessagesPerf.default 419 416 1.01:1
CheckboxMinimalPerf.default 3052 3008 1.01:1
DatepickerMinimalPerf.default 51329 50900 1.01:1
GridMinimalPerf.default 405 402 1.01:1
ItemLayoutMinimalPerf.default 1394 1382 1.01:1
ListWith60ListItems.default 688 679 1.01:1
MenuMinimalPerf.default 979 965 1.01:1
ReactionMinimalPerf.default 481 478 1.01:1
TreeWith60ListItems.default 199 197 1.01:1
Button.Fluent 676 669 1.01:1
ButtonSlotsPerf.default 650 652 1:1
ButtonUseCssPerf.default 900 899 1:1
ChatMinimalPerf.default 712 714 1:1
EmbedMinimalPerf.default 4448 4439 1:1
TreeMinimalPerf.default 870 874 1:1
Dropdown.Fluent 3212 3205 1:1
ButtonOverridesMissPerf.default 1860 1873 0.99:1
ButtonUseCssNestingPerf.default 1184 1200 0.99:1
DialogMinimalPerf.default 900 905 0.99:1
DropdownMinimalPerf.default 3149 3176 0.99:1
LayoutMinimalPerf.default 452 458 0.99:1
ListNestedPerf.default 652 658 0.99:1
MenuButtonMinimalPerf.default 1727 1752 0.99:1
SliderMinimalPerf.default 1663 1683 0.99:1
IconMinimalPerf.default 746 756 0.99:1
ToolbarMinimalPerf.default 1082 1093 0.99:1
Tooltip.Fluent 597 602 0.99:1
AlertMinimalPerf.default 332 339 0.98:1
HeaderMinimalPerf.default 438 445 0.98:1
ImageMinimalPerf.default 472 483 0.98:1
PopupMinimalPerf.default 749 767 0.98:1
PortalMinimalPerf.default 170 173 0.98:1
StatusMinimalPerf.default 835 853 0.98:1
CustomToolbarPrototype.default 3981 4056 0.98:1
VideoMinimalPerf.default 719 733 0.98:1
Icon.Fluent 755 770 0.98:1
ChatWithPopoverPerf.default 492 505 0.97:1
DropdownManyItemsPerf.default 814 838 0.97:1
LabelMinimalPerf.default 477 494 0.97:1
TextAreaMinimalPerf.default 572 591 0.97:1
RosterPerf.default 1285 1354 0.95:1
ProviderMinimalPerf.default 1042 1094 0.95:1

@ecraig12345 ecraig12345 merged commit 540e928 into microsoft:master Jan 27, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@Raghurk Raghurk Awaiting requested review from Raghurk

Assignees
No one assigned
Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubkon @fabricteam @msft-fluent-ui-bot @ecraig12345