Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charting: Tooltip disappear on escape click issue fixed in line chart #16491

Merged
merged 5 commits into from
Jan 21, 2021

Conversation

jameelakowsar
Copy link
Contributor

@jameelakowsar jameelakowsar commented Jan 15, 2021

Pull request checklist

Description of changes

Added 'hidden' and 'onDismiss' props to the callout to enable this feature.

Focus areas to test

Line chart

@msft-fluent-ui-bot msft-fluent-ui-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Jan 15, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a337485:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 15, 2021

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 1031 1017 5000
Breadcrumb mount 44677 44269 5000
Checkbox mount 1848 1737 5000
CheckboxBase mount 1416 1454 5000
ChoiceGroup mount 5475 5438 5000
ComboBox mount 980 972 1000
CommandBar mount 8100 8198 1000
ContextualMenu mount 15571 15763 1000
DefaultButton mount 1249 1236 5000
DetailsRow mount 3942 3876 5000
DetailsRowFast mount 3953 3984 5000
DetailsRowNoStyles mount 3707 3673 5000
Dialog mount 1619 1619 1000
DocumentCardTitle mount 1905 1896 1000
Dropdown mount 2883 2882 5000
FocusTrapZone mount 1872 1873 5000
FocusZone mount 1906 1961 5000
IconButton mount 1993 2008 5000
Label mount 348 371 5000
Layer mount 2228 2097 5000
Link mount 501 493 5000
MenuButton mount 1698 1691 5000
MessageBar mount 2267 2334 5000
Nav mount 3642 3648 1000
OverflowSet mount 1603 1600 5000
Panel mount 1587 1577 1000
Persona mount 928 885 1000
Pivot mount 1602 1581 1000
PrimaryButton mount 1417 1414 5000
Rating mount 8584 8528 5000
SearchBox mount 1465 1418 5000
Shimmer mount 2879 2879 5000
Slider mount 1641 1639 5000
SpinButton mount 5510 5573 5000
Spinner mount 438 450 5000
SplitButton mount 3494 3495 5000
Stack mount 560 545 5000
StackWithIntrinsicChildren mount 1649 1712 5000
StackWithTextChildren mount 5303 5222 5000
SwatchColorPicker mount 11134 11243 5000
TagPicker mount 3223 3038 5000
TeachingBubble mount 54040 53981 5000
Text mount 468 482 5000
TextField mount 1578 1597 5000
Toggle mount 923 939 5000
button mount 121 113 5000

@size-auditor
Copy link

size-auditor bot commented Jan 15, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8b706813fe018da6110f4c4929372df0f8a2034b (build)

@jameelakowsar jameelakowsar marked this pull request as ready for review January 15, 2021 13:04
@layershifter
Copy link
Member

@Raghurk can you please check latest changes?

@Raghurk Raghurk merged commit cbdf616 into microsoft:7.0 Jan 21, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

kubkon pushed a commit to kubkon/fluentui that referenced this pull request Jan 26, 2021
…microsoft#16491)

* Tooltip disappear after click on escape issue fixed

* Change files

* email updated in change log file

* updated deprecated property

* updated code to trigger build

Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <[email protected]>
@kubkon kubkon self-assigned this Jan 26, 2021
ecraig12345 pushed a commit that referenced this pull request Jan 27, 2021
- Line chart: Last circle callout issue fixed (#16556)
- Charting: Tooltip disappear on escape click issue fixed in line chart (#16491)

Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <[email protected]>
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants