Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making the prop 'showYAxisGridLines' as deprecated. #14872

Merged
merged 2 commits into from
Sep 3, 2020
Merged

making the prop 'showYAxisGridLines' as deprecated. #14872

merged 2 commits into from
Sep 3, 2020

Conversation

shivasai09
Copy link
Contributor

@shivasai09 shivasai09 commented Sep 3, 2020 •
edited
Loading

Pull request checklist

Description of changes

making the prop showYAxisGridLines as deprecated. since it not being used

Focus areas to test

area chart

@shivasai09 shivasai09 requested a review from Raghurk as a code owner September 3, 2020 05:56
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 119cbaa:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@shivasai09 shivasai09 closed this Sep 3, 2020
@shivasai09 shivasai09 reopened this Sep 3, 2020
@shivasai09 shivasai09 closed this Sep 3, 2020
@shivasai09 shivasai09 reopened this Sep 3, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented Sep 3, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 954 963 5000
ButtonNext mount 585 595 5000
Checkbox mount 1637 1669 5000
CheckboxBase mount 1383 1403 5000
CheckboxNext mount 1739 1816 5000
ChoiceGroup mount 5317 5256 5000
ChoiceGroupNext mount 5265 5236 5000
ComboBox mount 943 1006 1000
CommandBar mount 7822 8093 1000
ContextualMenu mount 13241 13135 1000
DefaultButton mount 1199 1161 5000
DetailsRow mount 3741 3713 5000
DetailsRowFast mount 3795 3783 5000
DetailsRowNoStyles mount 3545 3665 5000
Dialog mount 1624 1557 1000
DocumentCardTitle mount 1899 1898 1000
Dropdown mount 2759 2815 5000
FocusZone mount 1856 1800 5000
IconButton mount 1859 2090 5000
Label mount 360 341 5000
Link mount 485 480 5000
LinkNext mount 483 517 5000
MenuButton mount 1568 1544 5000
MessageBar mount 2110 2135 5000
MessageBarNext mount 2127 2120 5000
Nav mount 3482 3508 1000
OverflowSet mount 1463 1468 5000
OverflowSetNext mount 1108 1094 5000
Panel mount 1507 1600 1000
Persona mount 893 869 1000
Pivot mount 1493 1471 1000
PivotNext mount 1415 1414 1000
PrimaryButton mount 1302 1299 5000
SearchBox mount 1436 1348 5000
SearchBoxNext mount 1403 1445 5000
Shimmer mount 2797 2811 5000
ShimmerNext mount 2781 2828 5000
Slider mount 1576 1585 5000
SliderNext mount 2081 2017 5000
SpinButton mount 5261 5176 5000
SpinButtonNext mount 5341 5310 5000
Spinner mount 440 435 5000
SplitButton mount 3278 3303 5000
Stack mount 561 567 5000
StackWithIntrinsicChildren mount 2058 2118 5000
StackWithTextChildren mount 5540 5377 5000
SwatchColorPicker mount 10705 11813 5000
SwatchColorPickerNext mount 10783 10575 5000
TagPicker mount 2914 2904 5000
TeachingBubble mount 51271 51036 5000
TeachingBubbleNext mount 51541 50894 5000
Text mount 456 474 5000
TextField mount 1467 1476 5000
ThemeProvider mount 4243 4234 5000
ThemeProvider virtual-rerender 456 461 5000
Toggle mount 900 878 5000
ToggleNext mount 834 869 5000
button mount 133 109 5000

Perf Analysis (Fluent)

⚠️ 4 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1815 47 38.62:1 analysis
ButtonUseCssNestingPerf.default 64 47 1.36:1 analysis
ChatWithPopoverPerf.default 503 477 1.05:1 analysis
TreeWith60ListItems.default 225 224 1:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.5 0.94:1 2000 940
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 594
🔧 Checkbox.Fluent 0.68 0.39 1.74:1 1000 684
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 789
🔧 Dropdown.Fluent 3.06 0.51 6:1 1000 3055
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 754
🎯 Image.Fluent 0.08 0.11 0.73:1 5000 408
🔧 Slider.Fluent 1.61 0.37 4.35:1 1000 1612
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 371
🦄 Tooltip.Fluent 0.11 17 0.01:1 5000 558

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonUseCssPerf.default 73 49 1.49:1
TableMinimalPerf.default 473 405 1.17:1
ButtonMinimalPerf.default 201 173 1.16:1
AttachmentMinimalPerf.default 182 158 1.15:1
BoxMinimalPerf.default 399 355 1.12:1
LabelMinimalPerf.default 472 422 1.12:1
HeaderMinimalPerf.default 394 359 1.1:1
ImageMinimalPerf.default 430 393 1.09:1
FlexMinimalPerf.default 320 295 1.08:1
ReactionMinimalPerf.default 436 402 1.08:1
Text.Fluent 371 344 1.08:1
Tooltip.Fluent 558 519 1.08:1
ButtonSlotsPerf.default 678 633 1.07:1
MenuMinimalPerf.default 931 868 1.07:1
DividerMinimalPerf.default 383 362 1.06:1
GridMinimalPerf.default 359 338 1.06:1
ProviderMinimalPerf.default 1033 974 1.06:1
SkeletonMinimalPerf.default 443 419 1.06:1
TextAreaMinimalPerf.default 514 486 1.06:1
TooltipMinimalPerf.default 852 804 1.06:1
AnimationMinimalPerf.default 416 395 1.05:1
PopupMinimalPerf.default 717 681 1.05:1
RadioGroupMinimalPerf.default 451 430 1.05:1
SegmentMinimalPerf.default 384 366 1.05:1
IconMinimalPerf.default 696 661 1.05:1
Checkbox.Fluent 684 650 1.05:1
Icon.Fluent 754 718 1.05:1
ChatDuplicateMessagesPerf.default 443 425 1.04:1
FormMinimalPerf.default 458 441 1.04:1
InputMinimalPerf.default 1394 1342 1.04:1
ListMinimalPerf.default 521 503 1.04:1
LoaderMinimalPerf.default 799 765 1.04:1
PortalMinimalPerf.default 135 130 1.04:1
ProviderMergeThemesPerf.default 2019 1937 1.04:1
StatusMinimalPerf.default 717 687 1.04:1
Image.Fluent 408 391 1.04:1
AttachmentSlotsPerf.default 1212 1182 1.03:1
AvatarMinimalPerf.default 515 500 1.03:1
EmbedMinimalPerf.default 2064 1996 1.03:1
LayoutMinimalPerf.default 424 412 1.03:1
ToolbarMinimalPerf.default 1003 973 1.03:1
Button.Fluent 594 575 1.03:1
Dropdown.Fluent 3055 2977 1.03:1
AlertMinimalPerf.default 323 316 1.02:1
CardMinimalPerf.default 587 578 1.02:1
CarouselMinimalPerf.default 492 480 1.02:1
CheckboxMinimalPerf.default 2971 2920 1.02:1
DropdownManyItemsPerf.default 817 801 1.02:1
MenuButtonMinimalPerf.default 1675 1637 1.02:1
SplitButtonMinimalPerf.default 3990 3914 1.02:1
TextMinimalPerf.default 369 363 1.02:1
ChatMinimalPerf.default 661 655 1.01:1
DialogMinimalPerf.default 803 793 1.01:1
HeaderSlotsPerf.default 846 837 1.01:1
ItemLayoutMinimalPerf.default 1371 1351 1.01:1
RefMinimalPerf.default 214 212 1.01:1
TableManyItemsPerf.default 2343 2325 1.01:1
TreeMinimalPerf.default 893 880 1.01:1
Avatar.Fluent 940 932 1.01:1
DropdownMinimalPerf.default 3028 3033 1:1
CustomToolbarPrototype.default 3794 3788 1:1
Slider.Fluent 1612 1611 1:1
SliderMinimalPerf.default 1598 1609 0.99:1
VideoMinimalPerf.default 636 646 0.98:1
AccordionMinimalPerf.default 155 160 0.97:1
Dialog.Fluent 789 820 0.96:1
ListWith60ListItems.default 1017 1134 0.9:1
ListCommonPerf.default 771 1048 0.74:1
ListNestedPerf.default 651 934 0.7:1

@size-auditor
Copy link

size-auditor bot commented Sep 3, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 12e72defeec4e1c2a6c7326c9cef670f6c2b2a55 (build)

@shivasai09 shivasai09 closed this Sep 3, 2020
@shivasai09 shivasai09 reopened this Sep 3, 2020
@Raghurk Raghurk merged commit de0a066 into microsoft:master Sep 3, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@shivasai09 shivasai09 mentioned this pull request Sep 5, 2020
Closed
hutchcodes pushed a commit to hutchcodes/fluentui that referenced this pull request Sep 10, 2020
@shivasai09 @hutchcodes
making the prop 'showYAxisGridLines' as deprecated. (microsoft#14872)
6ac9579 
* making the prop 'showYAxisGridLines' as deprecated.

* Change files

Co-authored-by: v-sivsar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees
No one assigned
Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivasai09 @msft-github-bot @Raghurk