Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate prop showYAxisGridLines in AreaChart #14873

Closed
shivasai09 opened this issue Sep 3, 2020 · 2 comments
Closed

deprecate prop showYAxisGridLines in AreaChart #14873

shivasai09 opened this issue Sep 3, 2020 · 2 comments
Assignees
@Raghurk
Labels
Fluent UI react (v8) Issues about @fluentui/react (v8) Package: charting Type: Bug 🐛

Comments

@shivasai09
Copy link
Contributor

shivasai09 commented Sep 3, 2020 •
edited
Loading

in the pr
https://github.com/microsoft/fluentui/pull/14781/files we have removed the prop showYAxisGridLines, instead of making it deprecated.

now we need to raise the pr by introducing the same prop and deprecating it
@shivasai09 shivasai09 mentioned this issue Sep 3, 2020
Merged
2 tasks
@paulgildea paulgildea assigned Raghurk and unassigned khmakoto Sep 3, 2020
@paulgildea
Copy link
Member

@Raghurk FYI

@shivasai09
Copy link
Contributor Author

shivasai09 commented Sep 4, 2020 •
edited
Loading

fixed in #14872

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Raghurk Raghurk

Labels
Fluent UI react (v8) Issues about @fluentui/react (v8) Package: charting Type: Bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@khmakoto @Raghurk @paulgildea @shivasai09 @msft-github-bot