-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComboBox: Multi-select and other input issues #5929
Comments
We should think about how we prioritize and approach #5205 given these outstanding issues. |
While trying to debug #5834, it was also made apparent that ComboBox is not working properly in the most basic scenario when When trying to type Arial Black or Times New Roman, it types in all caps (and doesn't autocomplete). It also does not allow text deletion, which forces the user to select a different option to start over. |
Any updates on this and related issues? |
We need to revisit ComboBox holistically as there are numerous issues with it combined with the context of #5205, so I'll mark this blocked for now. |
There is a very similar behavior where when you have a controlled multi-select Combobox and supply a selectedkey prop, when the component renders the selected keys dont display until you give the combobox focus then click off of it. You can see this behavior on the Fabric Documentation site: But when you click the dropdown, you see it does in fact have items selected: I can file a separate bug if that makes more sense. |
I was working on the examples recently, and I'm pretty sure that both the ComboBox itself AND the example code to control the items are buggy. The example code is an interesting case study on why (with the current implementation) it's very difficult to have a controlled ComboBox which allows freeform options and behaves in a reasonable manner. I also tried to make an uncontrolled+freeform example and wasn't able to. @dcokely7 Thanks for reporting that issue. If you could open a separate GitHub issue, that might be good to help keep it from getting lost. |
Please address this issue asap. |
This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fabric React! |
Bug Report
Priorities and help requested:
Are you willing to submit a PR to fix? (Yes, No)
Requested priority: (Blocking, High, Normal, Low)
Products/sites affected: (if applicable)
Describe the issue:
On the 6.49.0 Fabric site, the following behavior occurs:
Actual behavior:
Input often does not update as user selects and collapses dropdown.
There are other issues related to input, so I'm going to reference them here as the cause or fix may be similar: #5917, #3061, #3055, #5834
Expected behavior:
Input updates as user selects and collapses dropdown.
If applicable, please provide a codepen repro:
Provided fixed version link above.
The text was updated successfully, but these errors were encountered: