Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox: Multi-select and other input issues #5929

Closed
JasonGore opened this issue Aug 14, 2018 · 9 comments
Closed

ComboBox: Multi-select and other input issues #5929

JasonGore opened this issue Aug 14, 2018 · 9 comments

Comments

@JasonGore
Copy link
Member

JasonGore commented Aug 14, 2018

Bug Report

  • Package version(s): 6.49.0
  • Browser and OS versions: Chrome

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No)

Requested priority: (Blocking, High, Normal, Low)

Products/sites affected: (if applicable)

Describe the issue:

On the 6.49.0 Fabric site, the following behavior occurs:

combobox

Actual behavior:

Input often does not update as user selects and collapses dropdown.

There are other issues related to input, so I'm going to reference them here as the cause or fix may be similar: #5917, #3061, #3055, #5834

Expected behavior:

Input updates as user selects and collapses dropdown.

If applicable, please provide a codepen repro:

Provided fixed version link above.

@JasonGore
Copy link
Member Author

We should think about how we prioritize and approach #5205 given these outstanding issues.

@natalieethell
Copy link
Contributor

natalieethell commented Aug 15, 2018

While trying to debug #5834, it was also made apparent that ComboBox is not working properly in the most basic scenario when allowFreeform is false and autoComplete is true. I've included a screen capture below using the example on the demo page (courtesy of @kysedate):

comboboxbug

When trying to type Arial Black or Times New Roman, it types in all caps (and doesn't autocomplete). It also does not allow text deletion, which forces the user to select a different option to start over.

@NZainchkovskiy
Copy link

Any updates on this and related issues?
Combobox is broken in many scenarios, and it's lasting a few months now.
This component is not supported any more?

@JasonGore JasonGore added the Status: Blocked Resolution blocked by another issue label Oct 30, 2018
@JasonGore
Copy link
Member Author

We need to revisit ComboBox holistically as there are numerous issues with it combined with the context of #5205, so I'll mark this blocked for now.

@dcokely7
Copy link

There is a very similar behavior where when you have a controlled multi-select Combobox and supply a selectedkey prop, when the component renders the selected keys dont display until you give the combobox focus then click off of it. You can see this behavior on the Fabric Documentation site:
https://developer.microsoft.com/en-us/fabric#/components/ComboBox

image

But when you click the dropdown, you see it does in fact have items selected:

image

I can file a separate bug if that makes more sense.

@ecraig12345
Copy link
Member

I was working on the examples recently, and I'm pretty sure that both the ComboBox itself AND the example code to control the items are buggy. The example code is an interesting case study on why (with the current implementation) it's very difficult to have a controlled ComboBox which allows freeform options and behaves in a reasonable manner. I also tried to make an uncontrolled+freeform example and wasn't able to.

@dcokely7 Thanks for reporting that issue. If you could open a separate GitHub issue, that might be good to help keep it from getting lost.

@StanTempAccount
Copy link

Please address this issue asap.

@micahgodbolt
Copy link
Member

micahgodbolt commented Dec 31, 2019

We've done a bunch of updates to the ComboBox recently. Would be good to see if this issue is still valid.

combo

@msft-github-bot
Copy link
Contributor

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fabric React!

@microsoft microsoft locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.