Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox sends bad onChanged after backspacing all characters #3055

Closed
IanVS opened this issue Oct 6, 2017 · 8 comments · Fixed by #6142
Closed

ComboBox sends bad onChanged after backspacing all characters #3055

IanVS opened this issue Oct 6, 2017 · 8 comments · Fixed by #6142

Comments

@IanVS
Copy link
Contributor

IanVS commented Oct 6, 2017

Bug Report

  • Package version(s): 5.5.0

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? No, probably not (sorry)

Requested priority: Normal

Products/sites affected: Nutshell CRM Outlook add-on

Describe the issue:

I am using an uncontrolled ComboBox on a form, allowFreeform set to true. I have found that when I backspace out all of the characters one at a time and then press enter, the value argument that is provided to onChanged is the last letter that was backspaced (the first letter of the original contents). See Provided codepen for a demonstration.

Actual behavior:

onChanged is called with a single character in the value argument.

Expected behavior:

onChanged is called with an empty string.

If applicable, please provide a codepen repro:

https://codepen.io/IanVS/pen/wryoby

@dzearing
Copy link
Member

@jspurlin

@fidabhittani
Copy link

Any update on this issues ... Any work arounds?

@michaelangotti
Copy link
Collaborator

@jspurlin Is this still on your radar?

@stale
Copy link

stale bot commented Jun 8, 2018

This issue has been automatically marked as stale because it has not activity for 30 days. It will be closed if no further activity occurs within 14 days of this comment. Thank you for your contributions to Fabric React!
Why am I receiving this notification?

@sebraddo
Copy link

sebraddo commented Jul 6, 2018

Also running into this issue, has anyone found a workaround for clearing combobox input?

@aslanovsergey
Copy link

Same here. Please increase priority some of my core features relies on this component

@kenotron
Copy link
Member

I thought I could do a quick fix on this, but the fix is VERY involved based on how this was actually coded.

@micahgodbolt micahgodbolt added this to the Backlog milestone Aug 28, 2018
@jspurlin
Copy link
Contributor

FYI, I've got a local fix for this. Need to finish testing and then will have a PR sent out

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.