Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox newly created freeform item is cleared with escape key #3061

Closed
IanVS opened this issue Oct 6, 2017 · 3 comments · Fixed by #6152
Closed

ComboBox newly created freeform item is cleared with escape key #3061

IanVS opened this issue Oct 6, 2017 · 3 comments · Fixed by #6152

Comments

@IanVS
Copy link
Contributor

IanVS commented Oct 6, 2017

Bug Report

  • Package version(s): 5.5.0

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? Perhaps, if pointed in the right direction.

Requested priority: Normal

Describe the issue:

I am having some difficulties with freeform-entered options in uncontrolled ComboBoxes. Specifically, after creating an option by typing it in and pressing enter, if I open the dropdown and press the escape key to close the dropdown/blur, the selection disappears. I've made a codepen to illustrate the issue.

Actual behavior:

Freeform-entered options can be cleared, leaving a blank field. onChanged does not fire, but the field remains blank.

Expected behavior:

Pressing escape would not clear out the selection, and would behave just as it does when choosing an option from the dropdown, opening the dropdown, and pressing escape.

If applicable, please provide a codepen repro:

https://codepen.io/IanVS/pen/YrexLg?editors=0011

@michaelangotti
Copy link
Collaborator

@jspurlin Is this one on your radar or should we close it?

@stale
Copy link

stale bot commented Jun 8, 2018

This issue has been automatically marked as stale because it has not activity for 30 days. It will be closed if no further activity occurs within 14 days of this comment. Thank you for your contributions to Fabric React!
Why am I receiving this notification?

@JasonGore
Copy link
Member

JasonGore commented Aug 14, 2018

With this same CodePen I'm also seeing this issue where showing the dropdown and just clicking elsewhere on the page adds a phantom option. There may be a race condition or improperly call callbacks calling this issue.

combobox3

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants