chore: update issue and PR templates

[EisenbergEffect]

Pull Request

📖 Description

Updating our issue and PR templates is the last piece of the work to refresh our GitHub usage approach. We'd like to have a friendly set of templates and guidance for the most common scenarios. This is my take on that based on some prior projects of mine as well as notes I've made over the last few months from team feedback.

Note: While it's technically possible to have multipe PR tempaltes, you can't select them through the UI. The submitter needs to know the template name and add it to the query string, which isn't very user friendly. For this reason, this PR sticks with a single PR template and instead re-organizes the checklists.

🎫 Issues

• Closes chore: refactor repeat select template by section #3259
• Closes [Proposal] GitHub Usage and Process #3495

👩‍💻 Reviewer Notes

This PR (manually) uses the new template, so take a moment to think through how you are experiencing the template right now. A primary characteristic of a good PR is to present an excellent reading experience since the PR will be read by many people, not only now but possibly months or years later. After considering this, have a look at the changed files in this PR. They are all markdown as this is a content-only change. No code is affected. The new templates make use of emojis and commented guidance for each section. What do you think of this approach?

📑 Test Plan

No testing was done as part of this PR other than viewing how files look on GitHub.

✅ Checklist

General

• I have followed the title guidelines for my PR
• I have included a change request file using $ yarn change - NOTE: Note implemented yet. Should we leave this off?
• I have added tests for my changes.
• I have tested my changes.
• I have updated the project documentation to reflect my changes.
• I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

This completes the known initial set of work to update our GitHub use for FAST. We'll continue to take feedback and make modification to our templates, labels, issues, PRs, projects, milestones, etc.

[nicholasrice]

Looks good! Just one thought above.

[awentzel]

Do we need the emoji's in the headings? Do they add value? To my eyes, they are a bit distracting and moves my focus away from the text.

[EisenbergEffect]

This is ready to go but I'm marking this as status:blocked for now. We'll unblock and merge once the new beachball release setup in in place.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[janechu]

Removed stale warning as this is temporarily blocked, not stale.

[awentzel]

'Find inaccuracies in the documentation or something missing?'

[awentzel]

@EisenbergEffect per your question regarding yarn change. This feature is in master, so you can include in the PR. We won't use it until we have finalized beachball implementation (it's been tested locally, just not in production scenarios. We need the production scenarios to be fired off manually by @chrisdholt, once that passes I have a quick edit to the CI and it's should run nightly from that point going forward.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[chrisdholt]

@EisenbergEffect I think we are ready to bring this in :)

[EisenbergEffect]

@chrisdholt Should I merge now or wait to do it as part of our meeting tomorrow?

[codeclimate]

Code Climate has analyzed commit 298679b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.2% (0.0% change).

View more on Code Climate.

[chrisdholt]

@chrisdholt Should I merge now or wait to do it as part of our meeting tomorrow?

I think you're probably good now to be honest. We can do it tomorrow as well, but I don't see a huge problem with merging prior to tomorrow.