chore: refactor repeat select template by section #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freefaller69
requested review from
EisenbergEffect,
radium-v,
eljefe223,
khamudom and
SamanthaAO
freefaller69
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
EisenbergEffect
approved these changes
Jun 9, 2020
Thanks again for your help in getting me past my last sticking point, @EisenbergEffect. |
SamanthaAO
approved these changes
Jun 9, 2020
SamanthaAO
reviewed
Jun 9, 2020
...website/src/app/components/content-placement-container/content-placement-container.styles.ts
Show resolved
Hide resolved
added 2 commits
June 9, 2020 16:04
radium-v
approved these changes
Jun 10, 2020
| )} | ||
| ` | ||
| )} | ||
| ${repeat(x => x.selectData(), template)} |
nicholasrice
approved these changes
Jun 10, 2020
chrisdholt
pushed a commit
that referenced
this pull request
Jun 11, 2020
* implement template select for reusability * fix feature card columns * fix feature counter number placement * fix hover styling in feature section * update framework template * Update design system imports * Consolidate css Co-authored-by: Michael Benson <[email protected]>
chrisdholt
pushed a commit
that referenced
this pull request
Jun 16, 2020
* implement template select for reusability * fix feature card columns * fix feature counter number placement * fix hover styling in feature section * update framework template * Update design system imports * Consolidate css Co-authored-by: Michael Benson <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor content placement container to select template based on section. The selectTemplate and selectData functions in the content-placement-container component pass the imported template and data based on the value of the select attribute provided, allowing for removal of the $when function. Section templates have been separated to their own individual files.
Update styling for feature section in content placement container.
Motivation & context
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist