Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI: Call Close() on vertical bar window when horizontal window is closed and vice versa #3106

Merged
merged 6 commits into from
Jun 5, 2024
Merged

PI: Call Close() on vertical bar window when horizontal window is closed and vice versa #3106

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
14a677d
update to call windowex_close on bar vertical and horizontal window
zadesai Jun 3, 2024
d217710
Use primarywindow HWND for clipboard monitoring
zadesai Jun 4, 2024
ae6fb04
PR feedback
zadesai Jun 4, 2024
f4c6038
update
zadesai Jun 4, 2024
818b4d7
start clipboardmonitor from barwindow
zadesai Jun 4, 2024
4451560
remove unwanted using statement
zadesai Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/PI/DevHome.PI/BarWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ public BarWindow()
_verticalWindow = new BarWindowVertical(_viewModel);

_horizontalWindow.Closed += Window_Closed;
_horizontalWindow.Closed += _verticalWindow.WindowEx_Closed;
zadesai marked this conversation as resolved.
Show resolved Hide resolved
_verticalWindow.Closed += Window_Closed;
_verticalWindow.Closed += _horizontalWindow.WindowEx_Closed;

_viewModel.PropertyChanged += ViewModel_PropertyChanged;
_settings.PropertyChanged += Settings_PropertyChanged;
Expand Down
2 changes: 1 addition & 1 deletion tools/PI/DevHome.PI/BarWindowHorizontal.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ private void SetDefaultPosition()
_restoreState.Width = settingSize.Width;
}

private void WindowEx_Closed(object sender, WindowEventArgs args)
public void WindowEx_Closed(object sender, WindowEventArgs args)
{
ClipboardMonitor.Instance.Stop();

Expand Down
2 changes: 1 addition & 1 deletion tools/PI/DevHome.PI/BarWindowVertical.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ private void ExternalToolButton_Click(object sender, RoutedEventArgs e)
}
}

private void WindowEx_Closed(object sender, WindowEventArgs args)
public void WindowEx_Closed(object sender, WindowEventArgs args)
{
if (_positionEventHook != IntPtr.Zero)
{
Expand Down
Loading