PI: Call Close() on vertical bar window when horizontal window is closed and vice versa #3106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description of the pull request / Additional comments
Bug: PI crashes on relaunch when ClipboardMonitoring is enabled and we close the bar from the vertical window.
Problem: When we launch PI, we start both the vertical and horizontal window. As a part of Horizontal window load, we start the ClipboardMonitor instance. Now, when we close vertical window, the horizontal window is still activated and ClipboardMonitor is still running. When we start a new instance of PI, the new horiztontalWindow tries to start ClipboardMonitor again and thus failing at Debug.Assert(ListenerHwnd == listeningWindow, "Why are we trying to start with a different hwnd?");
Fix: Call horizontal window Close() from verticalwindow when closed and vice versa.
Also, updated the ClipboardMonitor to listen on PrimaryWindow HWND instead of barwindow HWND.
Validation steps performed
PR checklist