Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI: Move SnapHelper out of Vertical Bar window and fix snapping bugs. #3094

Merged
merged 17 commits into from
Jun 5, 2024

Conversation

zadesai
Copy link
Contributor

@zadesai zadesai commented May 31, 2024

Detailed description of the pull request / Additional comments

Move snapping code out to SnapHelper.cs and removing dependency on BarWindowViewModel. This helped fix

  1. Docking and retargeting doesn't work #3034
  2. PI doesn't set foreground correctly when docked #3030
  3. Don't show snap icon when no app is attached
  4. Also, fixes unexpected elongation of vertical bar window when the user snaps and unsnaps the window multiple times.

Validation steps performed

  1. Launched PI
  2. Attached it to a process
  3. Snap bar window to targetapp
  4. Move the targetapp, and confirm bar window moves with it.
  5. Minimize and restore target app and confirm same actions are taken by bar window.
  6. Maximize target app and then confirm bar window is unsnapped to it.
  7. Restore target app, then overlap with other apps on it and then snap bar window. Both target app and barwindow come to foreground.
  8. Retarget barwindow to a different app and confirm the barwindow is snapped to the new targetapp

PR checklist

Copy link
Contributor

@timkur timkur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zadesai zadesai merged commit 5b10c31 into main Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docking and retargeting doesn't work
6 participants