Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for Windows DLL naming #630

Merged
merged 10 commits into from
Jan 9, 2018
Merged

Conversation

garethsb
Copy link
Contributor

Patch to get e.g. "cpprest140d_2_10.dll" as described in #577.

@msftclas
Copy link

msftclas commented Dec 15, 2017

CLA assistant check
All CLA requirements met.

@ras0219-msft
Copy link
Contributor

Thanks for the PR!

I simplified the abi-tag calculation to make it more compatible with the default cmake way of operating (i.e. using CMAKE_DEBUG_POSTFIX). While this does result in a different binary name than building with our embedded .sln, the important capability of distinguishing debug and release binaries is still preserved.

@ras0219-msft ras0219-msft merged commit d2acec6 into microsoft:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants