Inconsistent DLL naming in CMake vs. vcxproj builds at v2.10.0?

[garethsb]

As was the case for v2.9, at v2.10.0, the TargetName set in the project files in the repo is like "cpprest140d_2_10". E.g. https://github.com/Microsoft/cpprestsdk/blob/master/Release/src/build/vs14/casablanca140.vcxproj#L37

However, after using CMake to generate project files instead, the TargetName in the resulting cpprest.vcxproj is simply "cpprest_2_10", i.e. without the VS version or DebugFileSuffix.

Is this intentional, or should CMake builds include the VS/debug disambiguators in the same way?

Thanks.

[garethsb]

The repo .vcprox files also have Win32 and x64 (and ARM) builds. I understand a CMake-generated project supports a single platform, but I wonder whether the output directory should be made to still include e.g. "x64" in the path, as before?

[garethsb]

Of course, setting CMAKE_DEBUG_POSTFIX to "d" successfully gives us different TargetName values for Release and Debug, but not in the style of the existing project files, instead we have "cpprest_2_10d".

To get TargetName as e.g. "cpprest140d_2_10", I suggest replacing the binary versioning for WIN32 in Release/src/CMakeLists.txt

  set_target_properties(cpprest PROPERTIES
    OUTPUT_NAME "cpprest_${CPPREST_VERSION_MAJOR}_${CPPREST_VERSION_MINOR}")

With something like this:

  string(SUBSTRING ${CMAKE_VS_PLATFORM_TOOLSET} 1 -1 TOOLSET)
  set(CPPREST_VERSION_POSTFIX "_${CPPREST_VERSION_MAJOR}_${CPPREST_VERSION_MINOR}")
  foreach(CFG ${CMAKE_CONFIGURATION_TYPES})
    string(TOUPPER ${CFG} CFG)
    get_target_property(CFG_POSTFIX cpprest ${CFG}_POSTFIX)
    if (NOT CFG_POSTFIX)
      # forget "NOTFOUND"
      set(CFG_POSTFIX)
    endif()
    set_target_properties(cpprest PROPERTIES
      ${CFG}_POSTFIX "${TOOLSET}${CFG_POSTFIX}${CPPREST_VERSION_POSTFIX}")
  endforeach()

(Maybe there's a more concise way of doing that with generator expressions though.)

I also found I needed to make one change to improve the INSTALL experience on Windows. Without this change, find_package(cpprestsdk REQUIRED) doesn't work for me, I have to use find_package(cpprestsdk REQUIRED NAMES cpprestsdk cpprest).

To avoid that, when configuring cpprestsdk, I override CMAKE_INSTALL_PREFIX to be "C:\Program Files\cpprestsdk" rather than "C:\Program Files\cpprest".