Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

[Regression] luis import application fails (latest build off myget feed) #830

Closed
vishwacsena opened this issue Dec 7, 2018 · 2 comments · Fixed by #840
Closed

[Regression] luis import application fails (latest build off myget feed) #830

vishwacsena opened this issue Dec 7, 2018 · 2 comments · Fixed by #840
Assignees
@justinwilaby
Labels
4.2 December 15, 2018 Release approved Approved by the Triage Team P0 Must Fix. Release-blocker

Comments

@vishwacsena
Copy link
Contributor

Tool

Name: LUIS
Version: 2.0.7 (myget feed)
OS: Win10

Describe the bug

luis import application fails with the following -

this.addUserAgentInfo is not a function

To Reproduce

Steps to reproduce the behavior:

  1. uninstall luis cli
  2. point to the botbuilder myget feed
  3. install the luis cli
  4. try luis import application command and pass in valid arguments

Expected behavior

luis import application works. The version that is published to npm works but we have a regression in what's available in the nightly builds.

[bug]
@vishwacsena vishwacsena added 4.2 December 15, 2018 Release P0 Must Fix. Release-blocker labels Dec 7, 2018
@stevengum
Copy link
Member

@vishwacsena the ms-rest-js dependency needs to be pinned to 1.0.455 (see Azure/ms-rest-js#276 for more info)

@sgellock sgellock added the approved Approved by the Triage Team label Dec 7, 2018
@sgellock
Copy link
Member

sgellock commented Dec 7, 2018

can you fix this one, pin it to 1.0.455. and if you can also look at all the other tools.

justinwilaby added a commit that referenced this issue Dec 7, 2018
@justinwilaby
fixed #830 - pinned ms-rest to 1.0.455
14e871a
@justinwilaby justinwilaby mentioned this issue Dec 7, 2018
Merged
justinwilaby pushed a commit that referenced this issue Dec 7, 2018
Merge pull request #840 from Microsoft/jwilaby/#830-ms-rest
6a408fe 
fixed #830 - pinned ms-rest to 1.0.455
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@justinwilaby justinwilaby

Labels
4.2 December 15, 2018 Release approved Approved by the Triage Team P0 Must Fix. Release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed #830 - pinned ms-rest to 1.0.455 microsoft/botbuilder-tools
4 participants
@sgellock @justinwilaby @stevengum @vishwacsena