Version 1.0.465 removed addUserAgentInfo from ServiceClient which is a breaking change

[sgellock]

We generated code using 1.0.455. This generated code is crashing when our customers install botbuilder, as pulls in the 1.0.465.

Looks like this method was removed with the following commit:
523b891#diff-3b5c4e8e88ea4820a88a9584a654fe8cL144

Expected behavior
Following semver rules, patch versions should not be breaking.

[ghost]

Hi sgellock.
Yes, this was a mistake on our side. We were under the impression that the addUserAgentInfo() method was only called internally.
If you are interested in changing the user agent that a ServiceClient adds to outgoing requests, then I recommend using the ServiceClientOptions.userAgent property.
If you don't care about changing the user agent header, then I'd recommend running "autorest --reset" and then trying to regenerate. I just updated the latest version of our TypeScript generator and that should solve the problem.

[ghost]

Related to Azure/autorest.typescript#386.

[ghost]

@sgellock Did my previous comment solve the problem for you?

[sgellock]

We pinned to an earlier version that didn’t have the breaking change and published new versions of our bits. We believe your suggestion will work, but we haven’t tried it. From: Dan Schulte <[email protected]> Reply-To: Azure/ms-rest-js <[email protected]> Date: Monday, November 26, 2018 at 10:25 AM To: Azure/ms-rest-js <[email protected]> Cc: Scott Gellock <[email protected]>, Mention <[email protected]> Subject: Re: [Azure/ms-rest-js] Version 1.0.465 removed addUserAgentInfo from ServiceClient which is a breaking change (#276) @sgellock<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsgellock&data=02%7C01%7Cscott.gellock%40microsoft.com%7C1516c38754a040daa26e08d653cc9551%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636788535477531127&sdata=PATdgCItwAfS4aTqPOdn10g5lK3RAyxG6Qjkwy9Xq8o%3D&reserved=0> Did my previous comment solve the problem for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fms-rest-js%2Fissues%2F276%23issuecomment-441744970&data=02%7C01%7Cscott.gellock%40microsoft.com%7C1516c38754a040daa26e08d653cc9551%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636788535477541136&sdata=JreaIBDZVXA7nT0Bx2LPO1Q0Zqr3LFlhlq0%2FXe7BgYc%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAsxdxg95w1RZTy7XO9oidiUG9NvP-NDks5uzDIpgaJpZM4YnMLY&data=02%7C01%7Cscott.gellock%40microsoft.com%7C1516c38754a040daa26e08d653cc9551%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636788535477541136&sdata=jlZoCJ%2FseZ8ePbd%2BQ9PUP%2BhjklSfXYFQ%2FYYw0gRohYU%3D&reserved=0>.

[ghost]

I'm going to close this issue. Feel free to reopen if my proposed solution doesn't work.

[tomlm]

This is not a solution because it BREAKS existing clients that depend on this library.

you can't do this, it is unprofessional. If you are going to break it you need to do a major version change.

[ghost]

For future references, in #313 we changed ServiceClientOptions.userAgent to be either a string or a function that takes in the defaultUserAgent string and then returns the string that the ServiceClient will use. This should enable previous scenarios where people simply wanted to append to the existing user-agent string, and it should also enable other scenarios too (prepending, inserting, or whatever else someone wants to do with the defaultUserAgent string).