[Streaming, Engineering] Add integration tests for ChannelServiceRoutes #2582
+146
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sw-joelmut
deleted the
southworks/add/ChannelServiceRoutes-integration-tests
branch
sw-joelmut
restored the
southworks/add/ChannelServiceRoutes-integration-tests
branch
EricDahlvang
approved these changes
Jul 29, 2020
stevengum
approved these changes
Jul 29, 2020
|
@denscollo, this PR has feedback and is blocked via a conflict in the root |
|
@stevengum comments & conflicts solved! Thanks |
|
Thanks @denscollo! |
denscollo
deleted the
southworks/add/ChannelServiceRoutes-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1727
Description
This PR Fixes a bug using
del()method that has been deprecated in Express 4.x. and adds integration tests for ChannelServiceRoutes into the newbot-integration-testsfolder.More information can be found in the PR #1492.
Specific Changes
del()to register paths for DELETE methods.botbuilderwith restify and express.Testing
In the following images there is a sneak peek for
bot-integration-tests.