[Skills] Update ChannelServiceRoutes for improved Express support and add integration tests #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengum
requested review from
cleemullins,
christopheranderson,
johnataylor and
carlosscastro
a-b-r-o-w-n
approved these changes
Dec 10, 2019
stevengum
force-pushed
the
stgum/routes
branch
from
e90c37f to
3e69ac8
Compare
|
There the update Dependencies' version script is not updating the I'll investigate the script after 4.7 is released. |
|
Still a WIP, this PR should go to master instead. |
|
Close this PR, as it's targeting 4.7. Please retarget to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug around using the
del()method on Express Applications when this method has been deprecated in Express 4.x.The
WebServerinterface provided inChannelServiceRoutesalready had an optionaldelete()method which was added explicitly for Express Apps (Application.delete()).The
integration-testsfolder inlibraries/has been added with TypeScript tests to verify that ChannelServiceRoutes.register() adds the 12 Channel Service routes to the provided server.Specific Changes
ChanelServiceRoutesonly usingdel()to register paths for DELETE methods.