Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous Async suffix in some comments, error messages, etc. #2476

Merged
merged 3 commits into from
Jul 3, 2020

Conversation

v-kydela
Copy link
Contributor

@v-kydela v-kydela commented Jul 2, 2020

I became aware of a faulty error message when reading this customer's post: #2473

After looking into it, I discovered many cases where an Async suffix was leftover from C#. I kept over a hundred cases of it where actual methods had it in their names, for fear of breaking changes. I changed it in places where it was clearly wrong and there didn't seem to be any harm in changing it.

@v-kydela v-kydela requested a review from a team as a code owner July 2, 2020 23:41
@coveralls
Copy link

coveralls commented Jul 2, 2020

Pull Request Test Coverage Report for Build 143403

  • 1 of 3 (33.33%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.963%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs/src/skillDialog.ts 0 1 0.0%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 143291: -0.07%
Covered Lines: 12974
Relevant Lines: 15306

💛 - Coveralls

@stevengum stevengum requested review from axelsrz and EricDahlvang and removed request for DDEfromOR and tsuwandy July 3, 2020 20:25
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevengum stevengum merged commit ae29089 into master Jul 3, 2020
@stevengum stevengum deleted the kyled/asyncSuffix branch July 3, 2020 22:06
v-kydela pushed a commit that referenced this pull request Jul 8, 2020
@v-kydela v-kydela mentioned this pull request Jul 8, 2020
stevengum pushed a commit that referenced this pull request Jul 28, 2020
* Fix string that was missed in PR #2476

* Remove async suffix from functions in internal classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants