Kyled/async functions (#2506)

* Fix string that was missed in PR #2476 * Remove async suffix from functions in internal classes
microsoft · Jul 28, 2020 · 8a06762 · 8a06762
1 parent 4f1480d
commit 8a06762
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/libraries/botbuilder-ai/src/luisRecognizer.ts b/libraries/botbuilder-ai/src/luisRecognizer.ts
@@ -397,7 +397,7 @@ export class LuisRecognizer implements LuisRecognizerTelemetryClient {
                     entities: {},
                 });
             } else {
-                recognizerPromise = luisRecognizer.recognizeInternalAsync(context);
+                recognizerPromise = luisRecognizer.recognizeInternal(context);
             }
 
             return recognizerPromise

diff --git a/libraries/botbuilder-ai/src/luisRecognizerOptions.ts b/libraries/botbuilder-ai/src/luisRecognizerOptions.ts
@@ -22,6 +22,6 @@ export abstract class LuisRecognizerInternal {
 
     application: LuisApplication;
 
-    abstract recognizeInternalAsync(context: TurnContext): Promise<RecognizerResult>;
+    abstract recognizeInternal(context: TurnContext): Promise<RecognizerResult>;
 
 }
diff --git a/libraries/botbuilder-ai/src/luisRecognizerOptionsV2.ts b/libraries/botbuilder-ai/src/luisRecognizerOptionsV2.ts
@@ -51,7 +51,7 @@ export class LuisRecognizerV2 extends LuisRecognizerInternal {
 
     private luisClient: LuisClient;
 
-    async recognizeInternalAsync(context: TurnContext): Promise<RecognizerResult> {
+    async recognizeInternal(context: TurnContext): Promise<RecognizerResult> {
         const luisPredictionOptions = this.options;
         const utterance: string = context.activity.text || '';
 

diff --git a/libraries/botbuilder-ai/src/luisRecognizerOptionsV3.ts b/libraries/botbuilder-ai/src/luisRecognizerOptionsV3.ts
@@ -44,7 +44,7 @@ export class LuisRecognizerV3 extends LuisRecognizerInternal {
 
     public predictionOptions: LuisRecognizerOptionsV3;
 
-    async recognizeInternalAsync(context: TurnContext): Promise<RecognizerResult> {
+    async recognizeInternal(context: TurnContext): Promise<RecognizerResult> {
         const utterance: string = context.activity.text || '';
         if (!utterance.trim()) {
             // Bypass LUIS if the activity's text is null or whitespace

diff --git a/libraries/botbuilder-ai/src/qnaMaker.ts b/libraries/botbuilder-ai/src/qnaMaker.ts
@@ -255,7 +255,7 @@ export class QnAMaker implements QnAMakerTelemetryClient {
      * @param feedbackRecords Feedback records.
      */
     public async callTrainAsync(feedbackRecords: FeedbackRecords) {
-        return await this.trainUtils.callTrainAsync(feedbackRecords);
+        return await this.trainUtils.callTrain(feedbackRecords);
     }
 
     /**

diff --git a/libraries/botbuilder-ai/src/qnamaker-utils/trainUtils.ts b/libraries/botbuilder-ai/src/qnamaker-utils/trainUtils.ts
@@ -31,7 +31,7 @@ export class TrainUtils {
      * Train API to provide feedback.
      * @param feedbackRecords Feedback record list.
      */
-    public async callTrainAsync(feedbackRecords: FeedbackRecords) {
+    public async callTrain(feedbackRecords: FeedbackRecords) {
         if (!feedbackRecords) {
             throw new TypeError('Feedback records can not be null.');
         }
@@ -41,10 +41,10 @@ export class TrainUtils {
             return;
         }
 
-        await this.queryTrainAsync(feedbackRecords);
+        await this.queryTrain(feedbackRecords);
     }
 
-    private async queryTrainAsync(feedbackRecords: FeedbackRecords) {
+    private async queryTrain(feedbackRecords: FeedbackRecords) {
         const url: string = `${ this.endpoint.host }/knowledgebases/${ this.endpoint.knowledgeBaseId }/train`;
         var payloadBody = JSON.stringify({
             feedbackRecords: feedbackRecords

diff --git a/libraries/teams-scenarios/taskModule/src/taskModuleBot.ts b/libraries/teams-scenarios/taskModule/src/taskModuleBot.ts
@@ -47,7 +47,7 @@ export class TaskModuleBot  extends TeamsActivityHandler {
     }
 
     protected async handleTeamsTaskModuleSubmit(context: TurnContext, taskModuleRequest: TaskModuleRequest): Promise<TaskModuleResponse> {
-        var reply = MessageFactory.text("handleTeamsTaskModuleFetchAsync Value: " + JSON.stringify(taskModuleRequest));
+        var reply = MessageFactory.text("handleTeamsTaskModuleSubmit Value: " + JSON.stringify(taskModuleRequest));
         await context.sendActivity(reply);
 
         return {