Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConnectorClientOptions.baseUri optional #2447

Merged
merged 9 commits into from
Jul 1, 2020
Merged

Make ConnectorClientOptions.baseUri optional #2447

merged 9 commits into from
Jul 1, 2020

Conversation

EricDahlvang
Copy link
Member

Fixes #2439

@EricDahlvang EricDahlvang requested a review from a team as a code owner June 29, 2020 22:55
@coveralls
Copy link

coveralls commented Jun 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 142902

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.96%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 142854: -0.07%
Covered Lines: 12976
Relevant Lines: 15307
💛 - Coveralls

stevengum
stevengum approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@EricDahlvang EricDahlvang merged commit 1cabb54 into master Jul 1, 2020
@EricDahlvang EricDahlvang deleted the eric/optionalBaseUri branch July 1, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

baseUri should be optional for ConnectorClientOptions
3 participants
@EricDahlvang @coveralls @stevengum