Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseUri should be optional for ConnectorClientOptions #2439

Closed
amir-microsoft opened this issue Jun 28, 2020 · 1 comment · Fixed by #2447
Closed

baseUri should be optional for ConnectorClientOptions #2439

amir-microsoft opened this issue Jun 28, 2020 · 1 comment · Fixed by #2447
Assignees
@EricDahlvang
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P1 Painful if we don't fix, won't block releasing R10 Release 10 - August 17th, 2020
Milestone
R10

Comments

@amir-microsoft
Copy link

Versions

NodeJS v10.15.3
BotBuilder NodeJS SDK v4.9.2
My app is written is typescript

Describe the bug

When Using customized ConnectorClientOptions for BotFrameworkAdapterSettings, the baseUri is required, but passing a value for it causes the sdk to stop working - bot is unable to send messages

To Reproduce

const botFrameworkAdapterSettings: BotFrameworkAdapterSettings = {
appId,
appPassword,
clientOptions: { baseUri: undefined, httpClient: new CustomAxiosHttpClient() }
};
const adapter: BotFrameworkAdapter = new BotFrameworkAdapter(botFrameworkAdapterSettings);

Expected behavior

The baseUri should be optional at the very least, that will allow me to omit it, and still being able to transpile my typescript app without errors
@EricDahlvang EricDahlvang self-assigned this Jun 28, 2020
@EricDahlvang EricDahlvang mentioned this issue Jun 29, 2020
Merged
@axelsrz axelsrz added Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P1 Painful if we don't fix, won't block releasing R10 Release 10 - August 17th, 2020 labels Jun 29, 2020
@munozemilio munozemilio added this to the R10 milestone Jul 1, 2020
@stevengum
Copy link
Member

This was a bad one, thanks @EricDahlvang for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricDahlvang EricDahlvang

Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P1 Painful if we don't fix, won't block releasing R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
R10
Development

Successfully merging a pull request may close this issue.

Make ConnectorClientOptions.baseUri optional microsoft/botbuilder-js
5 participants
@axelsrz @EricDahlvang @stevengum @munozemilio @amir-microsoft