Remove unusable tenants #9921
Remove unusable tenants #9921
Conversation
| console.log(ex); | ||
| account.isStale = true; | ||
| return undefined; | ||
| console.log(`Could not refresh access token for ${JSON.stringify(tenant)} - silently removing the tenant from the user's account.`); |
There was a problem hiding this comment.
What about other general errors that occur while trying to refresh? Is the error not something we can check for more specifically?
It might be worth thinking about asking the user whether they want us to remove the tenant so that at least they're aware it's happening. (I'm a little worried most users won't know what that means though so not sure what the best approach is here)
There was a problem hiding this comment.
Talked offline - going to get this in and then if users have an issue with missing resources can look into exposing this more publically to them. But it should be enough of an edge case that this is fine to just do and log in the console.
| console.log(ex); | ||
| account.isStale = true; | ||
| return undefined; | ||
| console.log(`Could not refresh access token for ${JSON.stringify(tenant)} - silently removing the tenant from the user's account.`); |
There was a problem hiding this comment.
Talked offline - going to get this in and then if users have an issue with missing resources can look into exposing this more publically to them. But it should be enough of an edge case that this is fine to just do and log in the console.
This PR fixes #9885
So it seems like some users have access to tenants that they can't do resource management on. Keeping these tenants in the account seems silly as no operation will work on them.
Let's log and remove these tenants from the user profile in ADS. If they ever do get access to these accounts back, a simple restart of ADS will repopulate these and try again.