-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stuck in loop: "Error: Failed to get credential for account <email>. Please refresh the account" #8829
Comments
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: |
Readding account as suggested in #8766 did not resolve issue |
Same problem with insider build Azure Data Studio version: azuredatastudio-insiders 1.15.0-insider (362af3c, 2020-01-06T06:03:56.006Z) System Info
|
Can you try #7619 (comment) |
not sure if I'm missing something but after clicking on Add an account a browser with the URL |
That's supposed to redirect to the microsoft authentication site. Is it just getting stuck on that page? |
Why is it trying to open that page in https? That seems odd, do you have https everywhere configured? Or something to force https for localhost? |
I got the new auth process to work. |
@aaomidi do you have another idea? |
Do you have any logs you can share from the developer console? |
please have a look below:
|
I'm going to move this issue to march since I have been unable to repro this locally. |
This is also happening to me. I add my Azure account, and the browser logs me in successfully. The account is added: But when I try to expand my list of subscriptions, I'm told to refresh the account: I do this, and the browser logs me in successfully. But the message about refreshing the account remains. I tried deleting/re-adding the Azure account and uninstalling/reinstalling Azure Data Studio, but the error remains. I can only reproduce this on Ubuntu 16.04 Linux. I'm able to add my Azure account using the same Azure Data Studio build/commit on Windows. Let me know if there is any other information I can share. Version: 1.15.0-insider |
I will test this ASAP on Linux. There shouldn't be a big difference in how it works, so that's definitely weird. Are there any errors on the developer log? Help -> Toggle Developer Tools? |
Interesting, thank you! I'll check on it asap. |
I attached a debugger to the latest commit eeae87e and see the following error:
It's thrown by this line with the breakpoint: |
Hi, unfortunately this is an issue with the adal-node library :( We're in the process of updating our authentication scheme #9141. In the meantime you can enable device login #9147 (comment) |
We've hit some delays with the update to MSAL, hopefully April is an achievable goal. |
This should be fixed in the latest insiders. |
I'm still seeing issues that seem related to this - no matter how I try to refresh/remove/readd my account, I consistently get "Failed to get Azure account token for connection" when I try to log in. This is with the latest insiders build: Version Info
It looks like I'm hitting the condition created by #9921:
I've verified that I can actually perform DB operations in the portal, and this has worked in the past. On application launch, I get the error: Possibly interesting, the AAD tenant backing my subscription is set up with G suite as the IdP for AAD as described here: https://github.com/IAmFrench/GSuite-as-identity-Provider-IdP-for-Office-365-or-Azure-Active-Directory Let me know if I should open a new issue for this or how I can help debug. |
I'm guessing that GSuite being the IdP is probably part of the issue. I'm making a new PR #11208 to give us some more context on what the error was. Once it's merged, tomorrows insider build should have the latest changes. If this is urgent, you can build from source and test that way as well. (https://github.com/microsoft/azuredatastudio/wiki/Developer-Getting-Started-Guide) |
Tested out the new insider build today. Here's my console output from today's attempt:
|
@kevin-david Settings -> Azure -> "No System Keychain" - is it checked or not? You might want to disable the system keychain and try it again. You may also have some interesting information on startup of the application. |
@aaomidi sorry for the delay getting back to you. I installed the latest insiders build today and this appears to be fixed? Working Version Info
It doesn't work on the latest non-insiders build, as far as I can tell. Before I updated, I got an error I hadn't seen before: Hope this helps, and glad it seems to be working again! |
Yep the fix is only in insiders right now. I'm glad to see it's working now! |
I'll be closing this issue now - please test with the latest insiders and let me know if any issues pop up with this. If the issue is unrelated to this one please open a new one! |
How do I get an insiders build? |
Issue Type: Bug
Azure account shows error message:
Error: Failed to get credential for account . Please refresh the account
After refreshing account (browser opens, copying code, get confirmation) I can try again
Now I get an error in Linked Accounts pane:
You need to refresh the credentials for this account.
Can try over and over again.
Reinstalled application - no change
Azure Data Studio version: azuredatastudio 1.14.1 (f9b968c, 2019-12-24T02:42:26.303Z)
OS version: Windows_NT x64 10.0.18363
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: