MSAL & Govt/National Clouds #9141
Conversation
aaomidi
requested review from
anthonydresser,
chlafreniere,
kburtram and
smartguest
|
Apologies for the large PR. Issues in various areas of the application were popping up as I was enabling national clouds. |
|
Assuming the user has more than one cloud enabled:
For now, we're displaying both of these authentication mechanisms:
Both of these options work for national and public clouds. The mechanism behind the authentication of these hasn't changed much, except now you won't get the happy blue screen if there was an issue. We should design a sign-in failure page as well. |
|
@anthonydresser any idea why PR builds are failing? I wasn't able to understand that error. |
|
|
||
| const azureAccount = account as AzureAccount; | ||
|
|
||
| const response: TokenResponse = {}; |
There was a problem hiding this comment.
Parts of our code need a very weird mapping of tenants and subscriptions to tokens. So that's essentially what this does.
| let _handleFirewallRule = async (errorCode: number, errorMessage: string, connectionTypeId: string): Promise<azdata.HandleFirewallRuleResponse> => { | ||
| try { | ||
| let params: HandleFirewallRuleParams = { errorCode: errorCode, errorMessage: errorMessage, connectionTypeId: connectionTypeId }; | ||
| const x = await client.sendRequest(HandleFirewallRuleRequest.type, params); |
There was a problem hiding this comment.
This is debug and needs to be removed
|
Closing this in favor of #9618 - but I'm keeping the branch for future. |
Second take on Azure Authentication.
Implements version 2 of the Microsoft Identity Platform: https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-overview
Two authentication models are supported:
This changes some of the interface as well.
This PR ONLY enables US Govt Cloud - other clouds should just be a configuration change. I'll do those in a future PR.