Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting changes to release branch for database projects extension 1.4.5 #26101

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

zijchen
Copy link
Member

@zijchen zijchen commented Dec 11, 2024

Porting changes from #26049, #26053, #26095, and #26099 to the release branch for the database projects extension 1.4.5.

…#26049)

* Create project from quickpick

* Fix test

* Fix test
* Create project from quickpick

* Fix test

* Fix test

* Fix a bug in my last PR
* Update README.md

* Update buildHelper.ts

* Update newSdkSqlProjectTemplate.xml
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12286166388

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 41.715%

Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/sql-database-projects/src/controllers/projectController.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 11882455080: 0.003%
Covered Lines: 30722
Relevant Lines: 68916

💛 - Coveralls

@kburtram
Copy link
Member

@zijchen can you add a link to the issue that's been triaged for this port request?

@zijchen
Copy link
Member Author

zijchen commented Dec 12, 2024

@kburtram Yeah it's #26052

@kburtram kburtram merged commit 0eccd24 into release/1.50 Dec 12, 2024
12 checks passed
@kburtram kburtram deleted the zijchen/sqlproj-1.4.5 branch December 12, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code: Create project from database always uses SQL 2022 as target platform
4 participants