Fix a bug in my last PR #26053
Merged
Fix a bug in my last PR #26053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11808342124Details
💛 - Coveralls |
chlafreniere
approved these changes
Nov 13, 2024
kburtram
approved these changes
Nov 13, 2024
Benjin
approved these changes
Nov 13, 2024
zijchen
added a commit
that referenced
this pull request
Dec 11, 2024
* Create project from quickpick * Fix test * Fix test * Fix a bug in my last PR
kburtram
pushed a commit
that referenced
this pull request
Dec 12, 2024
….5 (#26101) * Fix target platform when creating project from database via quickpick (#26049) * Create project from quickpick * Fix test * Fix test * Fix a bug in my last PR (#26053) * Create project from quickpick * Fix test * Fix test * Fix a bug in my last PR * Update default SDK version to 0.2.5-preview (#26095) * Update README.md * Update buildHelper.ts * Update newSdkSqlProjectTemplate.xml * Update sql-database-projects extension to 1.4.5 (#26099)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally had this line in there, but I changed it to the one in #26049 thinking it's more readable, but they're not the same as now
thisbecomes undefined in the callback. Apparently in JS, passing function directly as argument binds it to a specific object instance, but using "lambda" functions doesn't. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions