Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Migration] New Migration Experience #24630

Merged
merged 51 commits into from
Oct 26, 2023
Merged

Conversation

krritik
Copy link
Contributor

@krritik krritik commented Oct 10, 2023

This PR:

Adds New Changes in migration Experience for SKU recommendation page and Assessment results page. For the new mocks please refer here, https://www.figma.com/file/UaD2zc58Y2iGKxnqDFQY3Q/End-to-End-Design-GA---SQL-Migration-ADS?type=design&node-id=1707-95074&mode=design&t=WNeaKDnNeGOyDZK6-0

Screenshots:
image

On click of start data collection:
image

On click of import data collection:
image

On click of Next and instance row:
image

On click of database row:
image

On click of issue row:
image

Screenshots in dark mode:
image
image

stuti149 and others added 30 commits September 5, 2023 21:26
* Adding Assessment Summary page

* adding comments

* resolving style comments
…ion (#24256)

* added new icon files

* updated the folder structure for skuRecommendationPage

* added new toolbar for SKU Recommendation

* added new toolbar for performance data collection

* minors changes in data collection toolbar

* removed duplicate icons/strings

* updated stopDataCollection icon
…24295)

* instance summary created

* adding resource strings

* resolving comment
…a Integration and Condition Handling (#24378)

* integration of assessment summary

* adding removed strings
* created Assessment Summary Card

* updated update function for assessment summary card

* added comments and localized strings

* added TODO comments

* added comments and localized strings

* resolved comments

* removed duplicate value

* Updated strings.ts
…ctionality (#24448)

* target type selection added

* added errors and removed dialog link

* Fixing target type dropdown and ready value

* add warning details

* css fixed

* comments resolved
* updated Recommendation page with assessment summary

* updated logic for assessment result

* added comments

* minor updates

* added back tde functions unchanged

* removed tde configuration, moved to next page

* some minor fixes like using enums instead of strings

* used direct assignment for text values
* created global variables for buttons in skuDataCollection toolbar

* added popup window for start DataCollection path selection

* added localized strings

* minor update-all caps for constant

* some minor fixes
* added functionality for start data collection at specified path

* updated comments
… box (#24597)

* added import performance dialog

* updated open folder icon

* updated alignment for the import performance dialog

* added localized strings

* updated skuRecommendationPage with openExisting option
…g on link click (#24602)

* add open sku recommendatio dialog on clicking view details

* fixed issue of opening multiple dialogs on link click
…24579)

* tde changes

* sqldatabase ready logo addition

* adding bottom border

* correcting ready with warning state for database

* resolved comments
…update notification. (#24610)

* added sku recommendation update notification message

* updated sku recommendation notification message

* removed extra info from assessment notification

* removed unused lines.
* recommended configuration added

* Database count corrected

* configuration changes

* card height fixed

* resolved comments

* build issues fix

---------

Co-authored-by: Ritik Kumar <[email protected]>
* Adding Assessment Summary page

* adding comments

* resolving style comments
…ion (#24256)

* added new icon files

* updated the folder structure for skuRecommendationPage

* added new toolbar for SKU Recommendation

* added new toolbar for performance data collection

* minors changes in data collection toolbar

* removed duplicate icons/strings

* updated stopDataCollection icon
…24295)

* instance summary created

* adding resource strings

* resolving comment
…a Integration and Condition Handling (#24378)

* integration of assessment summary

* adding removed strings
* created Assessment Summary Card

* updated update function for assessment summary card

* added comments and localized strings

* added TODO comments

* added comments and localized strings

* resolved comments

* removed duplicate value

* Updated strings.ts
…ctionality (#24448)

* target type selection added

* added errors and removed dialog link

* Fixing target type dropdown and ready value

* add warning details

* css fixed

* comments resolved
* updated Recommendation page with assessment summary

* updated logic for assessment result

* added comments

* minor updates

* added back tde functions unchanged

* removed tde configuration, moved to next page

* some minor fixes like using enums instead of strings

* used direct assignment for text values
* created global variables for buttons in skuDataCollection toolbar

* added popup window for start DataCollection path selection

* added localized strings

* minor update-all caps for constant

* some minor fixes
* added functionality for start data collection at specified path

* updated comments
… box (#24597)

* added import performance dialog

* updated open folder icon

* updated alignment for the import performance dialog

* added localized strings

* updated skuRecommendationPage with openExisting option
@stuti149 stuti149 requested a review from aasimkhan30 as a code owner October 18, 2023 12:09
@stuti149 stuti149 force-pushed the dev/stutijain/merge-main branch from f76a853 to a9d8845 Compare October 18, 2023 12:40
Copy link
Contributor

@smartura smartura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions.

* strings corrected

* display no target selected text

* adding empty screen ui

* undo access modifier
Copy link
Contributor Author

@krritik krritik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes. Giving Contributor Sign off.

@Ramudaykumar
Copy link
Contributor

Ramudaykumar commented Oct 25, 2023

I could not see the handling of Azure SQL MI recommendation and DB selection with DB count limit. Rest other looks good.

@stuti149
Copy link
Contributor

I could not see the handling of Azure SQL MI recommendation and DB selection with DB count limit. Rest other looks good.

This is handled. I hope you refer the below. Please look into assessmentsDetailsBody.ts

private async updateValuesOnSelectionAsync(migrationStateModel: MigrationStateModel) {
		const selectedDbsCount = this.selectedDbs()?.length;
		if (migrationStateModel._targetType === MigrationTargetType.SQLMI && selectedDbsCount > AZURE_SQL_MI_DB_COUNT_THRESHOLD) {
			this.wizard.nextButton.enabled = false;
			this.wizard.message = {
				level: azdata.window.MessageLevel.Error,
				text: constants.AZURE_SQL_MI_DB_COUNT_THRESHOLD_EXCEEDS_ERROR(AZURE_SQL_MI_DB_COUNT_THRESHOLD)
			};
		}

@stuti149 stuti149 merged commit 3e72dec into main Oct 26, 2023
10 checks passed
@stuti149 stuti149 deleted the dev/stutijain/merge-main branch October 26, 2023 06:51
siyao-Siyang pushed a commit that referenced this pull request Nov 1, 2023
* [New Migration Experience] Assessment Results Header Section (#24254)

* Adding Assessment Summary page

* adding comments

* resolving style comments

* [New Migration Experience] added toolbar for performance data collection (#24256)

* added new icon files

* updated the folder structure for skuRecommendationPage

* added new toolbar for SKU Recommendation

* added new toolbar for performance data collection

* minors changes in data collection toolbar

* removed duplicate icons/strings

* updated stopDataCollection icon

* [SQL Migration][New Migration Experience] Instance Summary created. (#24295)

* instance summary created

* adding resource strings

* resolving comment

* [SQL Migration][New Migration Experience] Assessment Results Page Data Integration and Condition Handling (#24378)

* integration of assessment summary

* adding removed strings

* [New Migration Workflow] New Assessment Summary Card (#24368)

* created Assessment Summary Card

* updated update function for assessment summary card

* added comments and localized strings

* added TODO comments

* added comments and localized strings

* resolved comments

* removed duplicate value

* Updated strings.ts

* [SQL Migration] [New Migration Experience] Select Target Platform Functionality (#24448)

* target type selection added

* added errors and removed dialog link

* Fixing target type dropdown and ready value

* add warning details

* css fixed

* comments resolved

* Assessment Summary backend changes (#24468)

* updated Recommendation page with assessment summary

* updated logic for assessment result

* added comments

* minor updates

* added back tde functions unchanged

* removed tde configuration, moved to next page

* some minor fixes like using enums instead of strings

* used direct assignment for text values

* Creating new start data collection popup window (#24472)

* created global variables for buttons in skuDataCollection toolbar

* added popup window for start DataCollection path selection

* added localized strings

* minor update-all caps for constant

* some minor fixes

* Added functionality for start data collection. (#24524)

* added functionality for start data collection at specified path

* updated comments

* added functionality for resfresh sku and stop data collection buttons (#24543)

* adding save assessment report (#24542)

* [New Migration Experience] Creating the new import performance dialog box (#24597)

* added import performance dialog

* updated open folder icon

* updated alignment for the import performance dialog

* added localized strings

* updated skuRecommendationPage with openExisting option

* updated editSkuRecommendationParam button to open dialog (#24598)

* [New Migration Experience] Added opening SkuRecommendationResultDialog on link click (#24602)

* add open sku recommendatio dialog on clicking view details

* fixed issue of opening multiple dialogs on link click

* [SQL Migration] TDE experience addition for New Migration Experience (#24579)

* tde changes

* sqldatabase ready logo addition

* adding bottom border

* correcting ready with warning state for database

* resolved comments

* [New Migration Experience] Created the assessment sku recommendation update notification. (#24610)

* added sku recommendation update notification message

* updated sku recommendation notification message

* removed extra info from assessment notification

* removed unused lines.

* [SQL Migration] Recommended configuration corrected (#24608)

* recommended configuration added

* Database count corrected

* configuration changes

* card height fixed

* resolved comments

* build issues fix

---------

Co-authored-by: Ritik Kumar <[email protected]>

* [New Migration Experience] Assessment Results Header Section (#24254)

* Adding Assessment Summary page

* adding comments

* resolving style comments

* [New Migration Experience] added toolbar for performance data collection (#24256)

* added new icon files

* updated the folder structure for skuRecommendationPage

* added new toolbar for SKU Recommendation

* added new toolbar for performance data collection

* minors changes in data collection toolbar

* removed duplicate icons/strings

* updated stopDataCollection icon

* [SQL Migration][New Migration Experience] Instance Summary created. (#24295)

* instance summary created

* adding resource strings

* resolving comment

* [SQL Migration][New Migration Experience] Assessment Results Page Data Integration and Condition Handling (#24378)

* integration of assessment summary

* adding removed strings

* [New Migration Workflow] New Assessment Summary Card (#24368)

* created Assessment Summary Card

* updated update function for assessment summary card

* added comments and localized strings

* added TODO comments

* added comments and localized strings

* resolved comments

* removed duplicate value

* Updated strings.ts

* [SQL Migration] [New Migration Experience] Select Target Platform Functionality (#24448)

* target type selection added

* added errors and removed dialog link

* Fixing target type dropdown and ready value

* add warning details

* css fixed

* comments resolved

* Assessment Summary backend changes (#24468)

* updated Recommendation page with assessment summary

* updated logic for assessment result

* added comments

* minor updates

* added back tde functions unchanged

* removed tde configuration, moved to next page

* some minor fixes like using enums instead of strings

* used direct assignment for text values

* Creating new start data collection popup window (#24472)

* created global variables for buttons in skuDataCollection toolbar

* added popup window for start DataCollection path selection

* added localized strings

* minor update-all caps for constant

* some minor fixes

* Added functionality for start data collection. (#24524)

* added functionality for start data collection at specified path

* updated comments

* added functionality for resfresh sku and stop data collection buttons (#24543)

* adding save assessment report (#24542)

* [New Migration Experience] Creating the new import performance dialog box (#24597)

* added import performance dialog

* updated open folder icon

* updated alignment for the import performance dialog

* added localized strings

* updated skuRecommendationPage with openExisting option

* updated editSkuRecommendationParam button to open dialog (#24598)

* [New Migration Experience] Added opening SkuRecommendationResultDialog on link click (#24602)

* add open sku recommendatio dialog on clicking view details

* fixed issue of opening multiple dialogs on link click

* [SQL Migration] TDE experience addition for New Migration Experience (#24579)

* tde changes

* sqldatabase ready logo addition

* adding bottom border

* correcting ready with warning state for database

* resolved comments

* [New Migration Experience] Created the assessment sku recommendation update notification. (#24610)

* added sku recommendation update notification message

* updated sku recommendation notification message

* removed extra info from assessment notification

* removed unused lines.

* [SQL Migration] Recommended configuration corrected (#24608)

* recommended configuration added

* Database count corrected

* configuration changes

* card height fixed

* resolved comments

* build issues fix

---------

Co-authored-by: Ritik Kumar <[email protected]>

* build fix

* VM configuration correction

* #24465 changes

* remove unnecessary files

* [New Migration Experience] Update Refresh Buttons + other changes. (#24618)

* added dropdown for refresh buttons

* updated Refresh DropDown and Toolbar buttons visibility

* added restart data collection button in toolbar

* update correct card loading for sku recommendation

* updated sku recommendation status in summary card

* updated disposables for skuRecommendation summary objects

* updated default path for start data collection

* removed unused else statement

* [New Migration Experience] [Resolved few bugs] (#24681)

* updated strings for subheadins and description

* changed focus in skuEditParametersDialog

* enabled correct buttons in toolbar in opening saved session

* moving change state for refresh dropdown functionality to toolbar

* updated sku recommendation notification message

* removed focus in skuEdit Paramater dialog

* added icon for refresh dropdown

* resolved comments

* resolving string comments

* resolving error comments

* resolved comments

* Create UI when No Target Type is selected (#24726)

* strings corrected

* display no target selected text

* adding empty screen ui

* undo access modifier

* fixed casing

* fixed comment

* updated version

---------

Co-authored-by: stuti149 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants