added functionality for refresh SKU Recommendation and Stop data collection buttons #24543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krritik
requested review from
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
extensions/sql-migration/src/wizard/skuRecommendation/skuRecommendationPage.ts
Show resolved
Hide resolved
brian-harris
approved these changes
Sep 29, 2023
stuti149
pushed a commit
that referenced
this pull request
Oct 9, 2023
stuti149
added a commit
that referenced
this pull request
Oct 26, 2023
* [New Migration Experience] Assessment Results Header Section (#24254) * Adding Assessment Summary page * adding comments * resolving style comments * [New Migration Experience] added toolbar for performance data collection (#24256) * added new icon files * updated the folder structure for skuRecommendationPage * added new toolbar for SKU Recommendation * added new toolbar for performance data collection * minors changes in data collection toolbar * removed duplicate icons/strings * updated stopDataCollection icon * [SQL Migration][New Migration Experience] Instance Summary created. (#24295) * instance summary created * adding resource strings * resolving comment * [SQL Migration][New Migration Experience] Assessment Results Page Data Integration and Condition Handling (#24378) * integration of assessment summary * adding removed strings * [New Migration Workflow] New Assessment Summary Card (#24368) * created Assessment Summary Card * updated update function for assessment summary card * added comments and localized strings * added TODO comments * added comments and localized strings * resolved comments * removed duplicate value * Updated strings.ts * [SQL Migration] [New Migration Experience] Select Target Platform Functionality (#24448) * target type selection added * added errors and removed dialog link * Fixing target type dropdown and ready value * add warning details * css fixed * comments resolved * Assessment Summary backend changes (#24468) * updated Recommendation page with assessment summary * updated logic for assessment result * added comments * minor updates * added back tde functions unchanged * removed tde configuration, moved to next page * some minor fixes like using enums instead of strings * used direct assignment for text values * Creating new start data collection popup window (#24472) * created global variables for buttons in skuDataCollection toolbar * added popup window for start DataCollection path selection * added localized strings * minor update-all caps for constant * some minor fixes * Added functionality for start data collection. (#24524) * added functionality for start data collection at specified path * updated comments * added functionality for resfresh sku and stop data collection buttons (#24543) * adding save assessment report (#24542) * [New Migration Experience] Creating the new import performance dialog box (#24597) * added import performance dialog * updated open folder icon * updated alignment for the import performance dialog * added localized strings * updated skuRecommendationPage with openExisting option * updated editSkuRecommendationParam button to open dialog (#24598) * [New Migration Experience] Added opening SkuRecommendationResultDialog on link click (#24602) * add open sku recommendatio dialog on clicking view details * fixed issue of opening multiple dialogs on link click * [SQL Migration] TDE experience addition for New Migration Experience (#24579) * tde changes * sqldatabase ready logo addition * adding bottom border * correcting ready with warning state for database * resolved comments * [New Migration Experience] Created the assessment sku recommendation update notification. (#24610) * added sku recommendation update notification message * updated sku recommendation notification message * removed extra info from assessment notification * removed unused lines. * [SQL Migration] Recommended configuration corrected (#24608) * recommended configuration added * Database count corrected * configuration changes * card height fixed * resolved comments * build issues fix --------- Co-authored-by: Ritik Kumar <[email protected]> * [New Migration Experience] Assessment Results Header Section (#24254) * Adding Assessment Summary page * adding comments * resolving style comments * [New Migration Experience] added toolbar for performance data collection (#24256) * added new icon files * updated the folder structure for skuRecommendationPage * added new toolbar for SKU Recommendation * added new toolbar for performance data collection * minors changes in data collection toolbar * removed duplicate icons/strings * updated stopDataCollection icon * [SQL Migration][New Migration Experience] Instance Summary created. (#24295) * instance summary created * adding resource strings * resolving comment * [SQL Migration][New Migration Experience] Assessment Results Page Data Integration and Condition Handling (#24378) * integration of assessment summary * adding removed strings * [New Migration Workflow] New Assessment Summary Card (#24368) * created Assessment Summary Card * updated update function for assessment summary card * added comments and localized strings * added TODO comments * added comments and localized strings * resolved comments * removed duplicate value * Updated strings.ts * [SQL Migration] [New Migration Experience] Select Target Platform Functionality (#24448) * target type selection added * added errors and removed dialog link * Fixing target type dropdown and ready value * add warning details * css fixed * comments resolved * Assessment Summary backend changes (#24468) * updated Recommendation page with assessment summary * updated logic for assessment result * added comments * minor updates * added back tde functions unchanged * removed tde configuration, moved to next page * some minor fixes like using enums instead of strings * used direct assignment for text values * Creating new start data collection popup window (#24472) * created global variables for buttons in skuDataCollection toolbar * added popup window for start DataCollection path selection * added localized strings * minor update-all caps for constant * some minor fixes * Added functionality for start data collection. (#24524) * added functionality for start data collection at specified path * updated comments * added functionality for resfresh sku and stop data collection buttons (#24543) * adding save assessment report (#24542) * [New Migration Experience] Creating the new import performance dialog box (#24597) * added import performance dialog * updated open folder icon * updated alignment for the import performance dialog * added localized strings * updated skuRecommendationPage with openExisting option * updated editSkuRecommendationParam button to open dialog (#24598) * [New Migration Experience] Added opening SkuRecommendationResultDialog on link click (#24602) * add open sku recommendatio dialog on clicking view details * fixed issue of opening multiple dialogs on link click * [SQL Migration] TDE experience addition for New Migration Experience (#24579) * tde changes * sqldatabase ready logo addition * adding bottom border * correcting ready with warning state for database * resolved comments * [New Migration Experience] Created the assessment sku recommendation update notification. (#24610) * added sku recommendation update notification message * updated sku recommendation notification message * removed extra info from assessment notification * removed unused lines. * [SQL Migration] Recommended configuration corrected (#24608) * recommended configuration added * Database count corrected * configuration changes * card height fixed * resolved comments * build issues fix --------- Co-authored-by: Ritik Kumar <[email protected]> * build fix * VM configuration correction * #24465 changes * remove unnecessary files * [New Migration Experience] Update Refresh Buttons + other changes. (#24618) * added dropdown for refresh buttons * updated Refresh DropDown and Toolbar buttons visibility * added restart data collection button in toolbar * update correct card loading for sku recommendation * updated sku recommendation status in summary card * updated disposables for skuRecommendation summary objects * updated default path for start data collection * removed unused else statement * [New Migration Experience] [Resolved few bugs] (#24681) * updated strings for subheadins and description * changed focus in skuEditParametersDialog * enabled correct buttons in toolbar in opening saved session * moving change state for refresh dropdown functionality to toolbar * updated sku recommendation notification message * removed focus in skuEdit Paramater dialog * added icon for refresh dropdown * resolved comments * resolving string comments * resolving error comments * resolved comments * Create UI when No Target Type is selected (#24726) * strings corrected * display no target selected text * adding empty screen ui * undo access modifier * fixed casing * fixed comment * updated version --------- Co-authored-by: stuti149 <[email protected]>
siyao-Siyang
pushed a commit
that referenced
this pull request
Nov 1, 2023
* [New Migration Experience] Assessment Results Header Section (#24254) * Adding Assessment Summary page * adding comments * resolving style comments * [New Migration Experience] added toolbar for performance data collection (#24256) * added new icon files * updated the folder structure for skuRecommendationPage * added new toolbar for SKU Recommendation * added new toolbar for performance data collection * minors changes in data collection toolbar * removed duplicate icons/strings * updated stopDataCollection icon * [SQL Migration][New Migration Experience] Instance Summary created. (#24295) * instance summary created * adding resource strings * resolving comment * [SQL Migration][New Migration Experience] Assessment Results Page Data Integration and Condition Handling (#24378) * integration of assessment summary * adding removed strings * [New Migration Workflow] New Assessment Summary Card (#24368) * created Assessment Summary Card * updated update function for assessment summary card * added comments and localized strings * added TODO comments * added comments and localized strings * resolved comments * removed duplicate value * Updated strings.ts * [SQL Migration] [New Migration Experience] Select Target Platform Functionality (#24448) * target type selection added * added errors and removed dialog link * Fixing target type dropdown and ready value * add warning details * css fixed * comments resolved * Assessment Summary backend changes (#24468) * updated Recommendation page with assessment summary * updated logic for assessment result * added comments * minor updates * added back tde functions unchanged * removed tde configuration, moved to next page * some minor fixes like using enums instead of strings * used direct assignment for text values * Creating new start data collection popup window (#24472) * created global variables for buttons in skuDataCollection toolbar * added popup window for start DataCollection path selection * added localized strings * minor update-all caps for constant * some minor fixes * Added functionality for start data collection. (#24524) * added functionality for start data collection at specified path * updated comments * added functionality for resfresh sku and stop data collection buttons (#24543) * adding save assessment report (#24542) * [New Migration Experience] Creating the new import performance dialog box (#24597) * added import performance dialog * updated open folder icon * updated alignment for the import performance dialog * added localized strings * updated skuRecommendationPage with openExisting option * updated editSkuRecommendationParam button to open dialog (#24598) * [New Migration Experience] Added opening SkuRecommendationResultDialog on link click (#24602) * add open sku recommendatio dialog on clicking view details * fixed issue of opening multiple dialogs on link click * [SQL Migration] TDE experience addition for New Migration Experience (#24579) * tde changes * sqldatabase ready logo addition * adding bottom border * correcting ready with warning state for database * resolved comments * [New Migration Experience] Created the assessment sku recommendation update notification. (#24610) * added sku recommendation update notification message * updated sku recommendation notification message * removed extra info from assessment notification * removed unused lines. * [SQL Migration] Recommended configuration corrected (#24608) * recommended configuration added * Database count corrected * configuration changes * card height fixed * resolved comments * build issues fix --------- Co-authored-by: Ritik Kumar <[email protected]> * [New Migration Experience] Assessment Results Header Section (#24254) * Adding Assessment Summary page * adding comments * resolving style comments * [New Migration Experience] added toolbar for performance data collection (#24256) * added new icon files * updated the folder structure for skuRecommendationPage * added new toolbar for SKU Recommendation * added new toolbar for performance data collection * minors changes in data collection toolbar * removed duplicate icons/strings * updated stopDataCollection icon * [SQL Migration][New Migration Experience] Instance Summary created. (#24295) * instance summary created * adding resource strings * resolving comment * [SQL Migration][New Migration Experience] Assessment Results Page Data Integration and Condition Handling (#24378) * integration of assessment summary * adding removed strings * [New Migration Workflow] New Assessment Summary Card (#24368) * created Assessment Summary Card * updated update function for assessment summary card * added comments and localized strings * added TODO comments * added comments and localized strings * resolved comments * removed duplicate value * Updated strings.ts * [SQL Migration] [New Migration Experience] Select Target Platform Functionality (#24448) * target type selection added * added errors and removed dialog link * Fixing target type dropdown and ready value * add warning details * css fixed * comments resolved * Assessment Summary backend changes (#24468) * updated Recommendation page with assessment summary * updated logic for assessment result * added comments * minor updates * added back tde functions unchanged * removed tde configuration, moved to next page * some minor fixes like using enums instead of strings * used direct assignment for text values * Creating new start data collection popup window (#24472) * created global variables for buttons in skuDataCollection toolbar * added popup window for start DataCollection path selection * added localized strings * minor update-all caps for constant * some minor fixes * Added functionality for start data collection. (#24524) * added functionality for start data collection at specified path * updated comments * added functionality for resfresh sku and stop data collection buttons (#24543) * adding save assessment report (#24542) * [New Migration Experience] Creating the new import performance dialog box (#24597) * added import performance dialog * updated open folder icon * updated alignment for the import performance dialog * added localized strings * updated skuRecommendationPage with openExisting option * updated editSkuRecommendationParam button to open dialog (#24598) * [New Migration Experience] Added opening SkuRecommendationResultDialog on link click (#24602) * add open sku recommendatio dialog on clicking view details * fixed issue of opening multiple dialogs on link click * [SQL Migration] TDE experience addition for New Migration Experience (#24579) * tde changes * sqldatabase ready logo addition * adding bottom border * correcting ready with warning state for database * resolved comments * [New Migration Experience] Created the assessment sku recommendation update notification. (#24610) * added sku recommendation update notification message * updated sku recommendation notification message * removed extra info from assessment notification * removed unused lines. * [SQL Migration] Recommended configuration corrected (#24608) * recommended configuration added * Database count corrected * configuration changes * card height fixed * resolved comments * build issues fix --------- Co-authored-by: Ritik Kumar <[email protected]> * build fix * VM configuration correction * #24465 changes * remove unnecessary files * [New Migration Experience] Update Refresh Buttons + other changes. (#24618) * added dropdown for refresh buttons * updated Refresh DropDown and Toolbar buttons visibility * added restart data collection button in toolbar * update correct card loading for sku recommendation * updated sku recommendation status in summary card * updated disposables for skuRecommendation summary objects * updated default path for start data collection * removed unused else statement * [New Migration Experience] [Resolved few bugs] (#24681) * updated strings for subheadins and description * changed focus in skuEditParametersDialog * enabled correct buttons in toolbar in opening saved session * moving change state for refresh dropdown functionality to toolbar * updated sku recommendation notification message * removed focus in skuEdit Paramater dialog * added icon for refresh dropdown * resolved comments * resolving string comments * resolving error comments * resolved comments * Create UI when No Target Type is selected (#24726) * strings corrected * display no target selected text * adding empty screen ui * undo access modifier * fixed casing * fixed comment * updated version --------- Co-authored-by: stuti149 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> added functionality for refresh SKU Recommendation and Stop data collection buttons
Sample output for SKU Recommendation value
