Adding fiilegroup name label to the input box and auto focus of newly added row #24536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssreerama
requested review from
corivera,
Charles-Gagnon,
barbaravaldez,
chlafreniere and
erinstellato-ms
|
Would it be possible to automatically select the newly added row when there are already other rows in the table? |
corivera
requested changes
Sep 28, 2023
corivera
approved these changes
Sep 29, 2023
ssreerama
changed the title
erinstellato-ms
approved these changes
Oct 2, 2023
siyao-Siyang
pushed a commit
that referenced
this pull request
Oct 12, 2023
… added row (#24536) * adds nameupdate textbox * fixed rows table remove button * input value update on row selection * using display prop instead of visible css property * select newly added cell automatically * sets remove button to next row after deleting a row
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a label to the filegroup input box and fixes the issue of row filegroup table remove button (where the button adds the rows instead of removing it). Also, Add and remove button automatically focuses on the newly added input box and next row after delete respectively.