Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing how to set name of new row in database properties #24320

Closed
kisantia opened this issue Sep 6, 2023 · 3 comments · Fixed by #24536
Closed

Confusing how to set name of new row in database properties #24320

kisantia opened this issue Sep 6, 2023 · 3 comments · Fixed by #24536

Comments

@kisantia
Copy link
Contributor

kisantia commented Sep 6, 2023

It's confusing that when creating a new row, the name is empty and the user needs to click on the cell to input the name in an input box that appears, and then that input box doesn't go away unless one of the first two rows is selected. The input box is aligned with the "Add..." button, so I accidentally thought that typing a name and then clicking "Add..." would add a new row with that name.

Can the cell in the table be editable to input the name so a separate input box at the bottom of the table isn't needed?

rowName

@ssreerama
Copy link
Contributor

Inline editing is not supportable for the table component for extensibility.

@erinstellato-ms , Do you see any other options here. Or can we go with opens new dialog on Add button and give the details there?

@erinstellato-ms
Copy link
Contributor

erinstellato-ms commented Sep 7, 2023

@ssreerama If we cannot edit within the table/cell, then I agree that selecting Add would open a new dialog for the user to enter the info there, the same as we do on the Files tab. That will be consistent behavior, and much less confusing.

For editing, because in the Filegroups tab there are only check boxes, I don't think we need an Edit button that would then open the dialog.

Good catch on finding that behavior confusing @kisantia.

@kisantia
Copy link
Contributor Author

kisantia commented Sep 7, 2023

Is using the DeclarativeTableComponent an option? It does support having input boxes. Ex of sql projects publish dialog using it with an input box in a declarative table component:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment