Replaced Filegroups tab tables with Declarative table component that supports inline editing #24355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssreerama
requested review from
corivera,
Charles-Gagnon,
alanrenmsft,
kisantia,
barbaravaldez and
chlafreniere
This was
linked to
issues
Sep 14, 2023
|
The declarative table disappearing on checkbox update issue could not be resolved for now and moving this PR to draft. |
|
@ssreerama just removed this from the November milestone. Generally we don't put PRs into milestones, btw |
|
[like] Sai Avishkar Sreerama reacted to your message:
…________________________________
From: Chris LaFreniere ***@***.***>
Sent: Tuesday, October 31, 2023 8:39:57 PM
To: microsoft/azuredatastudio ***@***.***>
Cc: Sai Avishkar Sreerama ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoft/azuredatastudio] Replaced Filegroups tab tables with Declarative table component that supports inline editing (PR #24355)
@ssreerama<https://github.com/ssreerama> just removed this from the November milestone. Generally we don't put PRs into milestones, btw
—
Reply to this email directly, view it on GitHub<#24355 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARY6ANNHRB4HFYAO7VMKNC3YCFOZ3AVCNFSM6AAAAAA4RCWSE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXHE4TONRZGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to inline edit the filegroup name by using the declarative table component. And fixes the add button issue with the memory optimized filegroup table(can add only one FG, disables when already fg present or enables)
Bug: #24309
Enhancement: #24320
TODO: 1. Selecting default checkboxes makes the table rows disappearing... [High Priority]