Use remote file dialog for database and server properties dialogs (#24390) #24412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corivera
requested review from
Charles-Gagnon,
alanrenmsft,
kburtram,
AkshayMata,
raymondtruong,
brian-harris,
junierch and
aasimkhan30
as code owners
Charles-Gagnon
approved these changes
Sep 13, 2023
| } | ||
|
|
||
| export interface FileBrowserProvider extends DataProvider { | ||
| openFileBrowser(ownerUri: string, expandPath: string, fileFilters: string[], changeFilter: boolean, showFoldersOnly?: boolean): Thenable<boolean>; |
There was a problem hiding this comment.
Did this never get the doc comment added to it? Please follow up with doing that in main....(it doesn't need to be ported over here)
There was a problem hiding this comment.
Woops, merged the PR after I got home and forgot about that. I'll update it in main
kisantia
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting change to release branch.
Related issues: #24313 and #24318