Use remote file dialog for database and server properties dialogs #24390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corivera
requested review from
Charles-Gagnon and
alanrenmsft
as code owners
| } | ||
|
|
||
| export interface FileBrowserProvider extends DataProvider { | ||
| openFileBrowser(ownerUri: string, expandPath: string, fileFilters: string[], changeFilter: boolean, showFoldersOnly?: boolean): Thenable<boolean>; |
There was a problem hiding this comment.
If you could add a doc comment for this (and then copy it over minus the new param to azdata.d.ts) that would be fantastic 😄
Charles-Gagnon
approved these changes
Sep 12, 2023
corivera
requested review from
kburtram,
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
brian-harris
approved these changes
Sep 13, 2023
corivera
added a commit
that referenced
this pull request
Sep 13, 2023
kisantia
pushed a commit
that referenced
this pull request
Sep 13, 2023
siyao-Siyang
pushed a commit
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only use the local file system dialog for some of the database and server properties path & file fields, but many SQL instances are on other machines. This change adds the same remote file dialog used for Attach and Restore to the properties dialogs.
As part of this work I had to add a flag to the file browser to be able to only show folders, since some of the properties fields are only folders, like the default database file location for example. Anytime the file browser is opened in folder-only mode the file filters box gets hidden and the other controls expand to fill the space.
With file filter:
Without file filter:
I also added a small fix for handling undefined values in the Attach Database dialog that I was hitting during some testing.
Currently waiting on the related changes in STS and the dataprotocol-client to be checked in before merging this.
microsoft/sqlops-dataprotocolclient#95
microsoft/sqltoolsservice#2238