Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server and database dialog width #24402

Closed
wants to merge 5 commits into from
Closed

Fix server and database dialog width #24402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ba6a47
fix dialogs width
barbaravaldez Sep 13, 2023
6659c84
add constants
barbaravaldez Sep 13, 2023
b57bd25
enable server proeprties and database properties
barbaravaldez Sep 13, 2023
35a5d0f
revert changes
barbaravaldez Sep 13, 2023
e672833
Merge branch 'main' into bavaldez/fixDialogWidth
barbaravaldez Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extensions/mssql/src/objectManagement/ui/databaseDialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import * as vscode from 'vscode';
const MAXDOP_Max_Limit = 32767;
const PAUSED_RESUMABLE_INDEX_Max_Limit = 71582;
const DscTableRowLength = 15;
const Dialog_Width = '650px';

export class DatabaseDialog extends ObjectManagementDialogBase<Database, DatabaseViewInfo> {
// Database Properties tabs
Expand Down Expand Up @@ -118,6 +119,7 @@ export class DatabaseDialog extends ObjectManagementDialogBase<Database, Databas


constructor(objectManagementService: IObjectManagementService, options: ObjectManagementDialogOptions) {
options.width = Dialog_Width;
super(objectManagementService, options);
}

Expand Down
3 changes: 3 additions & 0 deletions extensions/mssql/src/objectManagement/ui/serverPropertiesDialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import * as localizedConstants from '../localizedConstants';
import * as constants from '../constants';
import { Server, ServerViewInfo, NumaNode, AffinityType, ServerLoginMode, AuditLevel } from '../interfaces';

const Dialog_Width = '560px';

export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, ServerViewInfo> {
private generalTab: azdata.Tab;
private readonly generalTabId: string = 'generalId';
Expand Down Expand Up @@ -90,6 +92,7 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
private shouldRestartServer: boolean = false;

constructor(objectManagementService: IObjectManagementService, options: ObjectManagementDialogOptions) {
options.width = Dialog_Width;
super(objectManagementService, options);
this.disposables.push(this.dialogObject.onClosed(async (reason: azdata.window.CloseReason) => {
if (reason === 'ok') {
Expand Down