Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server and database dialog width #24402

Closed
wants to merge 5 commits into from
Closed

Conversation

barbaravaldez
Copy link
Contributor

@barbaravaldez barbaravaldez commented Sep 13, 2023

  1. Fix dialog width to fit the horizontal tabs:
databasePropertiesWidth serverPropertiesWidth

For: #24403

@barbaravaldez barbaravaldez requested review from corivera, Charles-Gagnon and ssreerama and removed request for corivera and Charles-Gagnon September 13, 2023 18:40
@barbaravaldez barbaravaldez changed the title Fix server and database dialog width Fix server and database dialog width and enable the object properties commands Sep 13, 2023
@ssreerama
Copy link
Contributor

Is this a temporary update to avoid the scroll bar? Should we also adjust the input items to occupy the full width?

@barbaravaldez
Copy link
Contributor Author

Is this a temporary update to avoid the scroll bar? Should we also adjust the input items to occupy the full width?

@erinstellato-ms, any thoughts here for adjusting the width for the other items in the dialog?

@erinstellato-ms
Copy link
Contributor

@barbaravaldez Can you explain what you mean by "adjusting the width for the other items in the dialog"? I need a visual (before and after) if possible...

@corivera
Copy link
Member

@barbaravaldez Could you break out the package.json changes into a separate PR? I don't think the UX width changes would hit the shiproom bar for ask mode.

@ssreerama
Copy link
Contributor

@erinstellato-ms , increasing the input textbox widths to fit the increased dialog width
image

@barbaravaldez barbaravaldez changed the title Fix server and database dialog width and enable the object properties commands Fix server and database dialog width Sep 13, 2023
@erinstellato-ms
Copy link
Contributor

@barbaravaldez I don't think we need to increase the width of the textboxes just because the window is wider.

However, in the DB properties that @ssreerama did, he does have a scrollbar at the top of the window. Can we be consistent between the two properties windows? Either both have a scrollbar, or neither does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants