-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix server and database dialog width #24402
Conversation
Is this a temporary update to avoid the scroll bar? Should we also adjust the input items to occupy the full width? |
@erinstellato-ms, any thoughts here for adjusting the width for the other items in the dialog? |
@barbaravaldez Can you explain what you mean by "adjusting the width for the other items in the dialog"? I need a visual (before and after) if possible... |
@barbaravaldez Could you break out the package.json changes into a separate PR? I don't think the UX width changes would hit the shiproom bar for ask mode. |
@erinstellato-ms , increasing the input textbox widths to fit the increased dialog width |
@barbaravaldez I don't think we need to increase the width of the textboxes just because the window is wider. However, in the DB properties that @ssreerama did, he does have a scrollbar at the top of the window. Can we be consistent between the two properties windows? Either both have a scrollbar, or neither does. |
For: #24403