handle error scenarios for validity check #24393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
approved these changes
Sep 13, 2023
kisantia
approved these changes
Sep 13, 2023
barbaravaldez
pushed a commit
that referenced
this pull request
Sep 13, 2023
kisantia
pushed a commit
that referenced
this pull request
Sep 13, 2023
Co-authored-by: Alan Ren <[email protected]>
siyao-Siyang
pushed a commit
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@barbaravaldez reached out to me for help on this issue: #24200
I noticed the following problems while changing the value (valid to invalid or invalid to valid), apparently, some components are not registered or disposed properly.
I think we should add warning for these scenarios as a safe guard. and in the meanwhile, @barbaravaldez, please investigate what caused the component to be undefined and fix it.