Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply button not available after updating max server memory #24200

Closed
erinstellato-ms opened this issue Aug 22, 2023 · 3 comments
Closed

Apply button not available after updating max server memory #24200

erinstellato-ms opened this issue Aug 22, 2023 · 3 comments

Comments

@erinstellato-ms
Copy link
Contributor

erinstellato-ms commented Aug 22, 2023

  1. Connect to a server (e.g. SQL 2022 in my scenario)
  2. Right-click on the server and select Properties
  3. Go to the Memory tab
  4. Change Max server memory by using the up/down arrows - the Apply button is available.
  5. Highlight text and start typing a new value, you'll see the message that the value must be greater than 128. Even with a valid value, the Apply button doesn't appear.

I am guessing that the check for a valid value is causing the issue. Would it be possible to check AFTER the user either changes focus to something else, or when they select Apply?

Also note: in SSMS, if a value less than 128 is entered, it will automatically change to 128. That may be a better option here...

ADS_changeprop.mp4

Version: 1.46.0-insider (user setup)
Commit: d5a9c17
Date: 2023-08-22T18:08:21.002Z
VS Code: 1.79.2
Electron: 22.3.14
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.22621

@barbaravaldez
Copy link
Contributor

Oh ok so we want to update the value and show an error message right?

@barbaravaldez barbaravaldez self-assigned this Aug 22, 2023
@erinstellato-ms
Copy link
Contributor Author

Oh ok so we want to update the value and show an error message right?

I think if you automatically set the value to 128 if they enter something below that, then there should not be a need for an error message. Unless I'm missing something?

@lucyzhang929
Copy link
Contributor

This happens for Curser Threshold field in Advanced tab too.
While typing "-1" the negative sign causes an error and the Apply button is not available afterwards.
Script button seems to work as expected.

Screen.Recording.2023-09-06.at.3.26.32.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants