Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query store capture policy section is enabling on non-custom capture mode #24371

Closed
ssreerama opened this issue Sep 11, 2023 · 0 comments · Fixed by #24361
Closed

Query store capture policy section is enabling on non-custom capture mode #24371

ssreerama opened this issue Sep 11, 2023 · 0 comments · Fixed by #24361
Assignees
@ssreerama
Labels
Approved Area - Query Store Bug Triage: Done

Comments

@ssreerama
Copy link
Contributor

  • Azure Data Studio Version:
  • OS Version:

Steps to Reproduce:

  1. Open database properties
  2. Navigate to query store tab
  3. set querystore capture mode to any option but custom (now capture policy section is disabled)
  4. modify the operation mode and observe the capture policy options are getting enabled on non-custom mode.

Does this issue occur when all extensions are disabled?: Yes/No
@ssreerama ssreerama self-assigned this Sep 11, 2023
ssreerama added a commit that referenced this issue Sep 11, 2023
@ssreerama
Query store capture policy section is enabling on non-custom capture …
5c42313 
…mode #24371
@ssreerama ssreerama mentioned this issue Sep 11, 2023
Merged
@ssreerama ssreerama linked a pull request Sep 12, 2023 that will close this issue
Database properties options fixes #24361
Merged
ssreerama added a commit that referenced this issue Sep 12, 2023
@ssreerama
Database properties options fixes (#24361)
96c4257 
* fix for File size input in DB properties can be decremented into the negative #24307

* Some DB Scoped Config options are sentence cased #24196

* cannot add a file with filestream data filegroup type #24359

* DB Scoped Secondary values aren't updated when hidden #24197

* DB Scoped Config shows secondary values for non-secondary options #24192

* Query store capture policy section is enabling on non-custom capture mode #24371

* queryStore WaitStatistics options should be a dropdown #24372
@ssreerama ssreerama mentioned this issue Sep 12, 2023
Merged
kisantia pushed a commit that referenced this issue Sep 12, 2023
@ssreerama
Cherry Pick - Database properties fixes (#24383)
4499f04 
* fix for File size input in DB properties can be decremented into the negative #24307

* Some DB Scoped Config options are sentence cased #24196

* cannot add a file with filestream data filegroup type #24359

* DB Scoped Secondary values aren't updated when hidden #24197

* DB Scoped Config shows secondary values for non-secondary options #24192

* Query store capture policy section is enabling on non-custom capture mode #24371

* queryStore WaitStatistics options should be a dropdown #24372
siyao-Siyang pushed a commit that referenced this issue Oct 12, 2023
@ssreerama @siyangMicrosoft
Database properties options fixes (#24361)
e9b6d1b 
* fix for File size input in DB properties can be decremented into the negative #24307

* Some DB Scoped Config options are sentence cased #24196

* cannot add a file with filestream data filegroup type #24359

* DB Scoped Secondary values aren't updated when hidden #24197

* DB Scoped Config shows secondary values for non-secondary options #24192

* Query store capture policy section is enabling on non-custom capture mode #24371

* queryStore WaitStatistics options should be a dropdown #24372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssreerama ssreerama

Labels
Approved Area - Query Store Bug Triage: Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Database properties options fixes microsoft/azuredatastudio
3 participants
@kenvanhyning @cssuh @ssreerama