Fix bug: web app name incorrect in prompt message #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummerSun
changed the title
Eskibear
reviewed
Oct 16, 2018
| @@ -137,17 +132,17 @@ public void stopWebApp() { | |||
|
|
|||
| private class DeleteWebAppAction extends AzureNodeActionPromptListener { | |||
| DeleteWebAppAction() { | |||
| super(WebAppNode.this, String.format(DELETE_WEBAPP_PROMPT_MESSAGE, getWebAppName()), | |||
| super(WebAppNode.this, String.format(DELETE_WEBAPP_PROMPT_MESSAGE, getName()), | |||
There was a problem hiding this comment.
the protected member webAppName is supposed to keep the correct value, so what's the root cause?
There was a problem hiding this comment.
webAppName is not initialized when calling loadActions from parent class when we change to use the base class WebAppBaseNode.
The sequence is:
WebAppNode constructor -> WebAppBaseNode constructor(super) -> loadActions -> DeleteWebAppAction constructor -> getWebAppName -> ... -> back to WebAppNode constructor to init the webAppName.
Eskibear
approved these changes
Oct 17, 2018
andxu
pushed a commit
to andxu/azure-tools-for-java
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2215
The
nameis initialized when loadActions, notwebAppName.