Skip to content

Commit

Permalink
Fix bug: web app name incorrect in prompt message (#2217)
Browse files Browse the repository at this point in the history
  • Loading branch information
Summer authored Oct 18, 2018
1 parent 568e555 commit 3af634d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import java.io.IOException;
import java.util.HashMap;
import java.util.Map;
import com.microsoft.azuretools.azurecommons.helpers.AzureCmdException;
import com.microsoft.azuretools.telemetry.AppInsightsConstants;
import com.microsoft.tooling.msservices.components.DefaultLoader;
import com.microsoft.tooling.msservices.serviceexplorer.NodeActionEvent;
Expand All @@ -36,7 +35,7 @@
import com.microsoft.tooling.msservices.serviceexplorer.azure.webapp.base.WebAppBaseState;

public class WebAppNode extends WebAppBaseNode implements WebAppNodeView {
private static final String DELETE_WEBAPP_PROMPT_MESSAGE = "This operation will delete Web App %s.\n"
private static final String DELETE_WEBAPP_PROMPT_MESSAGE = "This operation will delete the Web App: %s.\n"
+ "Are you sure you want to continue?";
private static final String DELETE_WEBAPP_PROGRESS_MESSAGE = "Deleting Web App";
private static final String LABEL = "WebApp";
Expand All @@ -57,6 +56,7 @@ public WebAppNode(WebAppModule parent, String subscriptionId, String webAppId, S
this.propertyMap = propertyMap;
webAppNodePresenter = new WebAppNodePresenter<>();
webAppNodePresenter.onAttachView(WebAppNode.this);
loadActions();
}

@Override
Expand Down Expand Up @@ -142,12 +142,12 @@ private class DeleteWebAppAction extends AzureNodeActionPromptListener {
}

@Override
protected void azureNodeAction(NodeActionEvent e) throws AzureCmdException {
protected void azureNodeAction(NodeActionEvent e) {
getParent().removeNode(getSubscriptionId(), getWebAppId(), WebAppNode.this);
}

@Override
protected void onSubscriptionsChanged(NodeActionEvent e) throws AzureCmdException {
protected void onSubscriptionsChanged(NodeActionEvent e) {
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ public WebAppBaseNode(final String id, final String name, final String label, fi
this.subscriptionId = subscriptionId;
this.os = StringUtils.capitalize(os.toLowerCase());
this.hostName = hostName;
loadActions();
}

protected static String getIcon(final String os, final String label, final WebAppBaseState state) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public DeploymentSlotNode(final String slotId, final String webAppId, final Depl
this.slotName = name;
this.presenter = new DeploymentSlotNodePresenter();
this.presenter.onAttachView(this);
loadActions();
}

@Override
Expand Down

0 comments on commit 3af634d

Please sign in to comment.