Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename appcenter.podspec to appcenter-core to avoid conflicts #789

Merged
merged 8 commits into from
Jan 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# App Center SDK for React Native Change Log

## Version 2.6.2 (Under development)

### App Center

#### iOS

* **[Fix]** Fix an error where **appcenter.podspec.json** could not be found when using CocoaPods version 1.8.x.
* **[Fix]** Fix issues with `use_frameworks!` directive.
russelarms marked this conversation as resolved.
Show resolved Hide resolved

___

## Version 2.6.1

### App Center
Expand Down
1 change: 1 addition & 0 deletions appcenter-analytics/ios/appcenter-analytics.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ Pod::Spec.new do |s|
s.dependency 'AppCenterReactNativeShared'
s.dependency 'AppCenter/Analytics'
s.dependency 'React'
s.static_framework = true
end
1 change: 1 addition & 0 deletions appcenter-auth/ios/appcenter-auth.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ Pod::Spec.new do |s|
s.dependency 'AppCenterReactNativeShared'
s.dependency 'AppCenter/Auth'
s.dependency 'React'
s.static_framework = true
end
1 change: 1 addition & 0 deletions appcenter-crashes/ios/appcenter-crashes.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ Pod::Spec.new do |s|
s.dependency 'AppCenterReactNativeShared'
s.dependency 'AppCenter/Crashes'
s.dependency 'React'
s.static_framework = true
end
1 change: 1 addition & 0 deletions appcenter-data/ios/appcenter-data.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ Pod::Spec.new do |s|
s.dependency 'AppCenterReactNativeShared'
s.dependency 'AppCenter/Data'
s.dependency 'React'
s.static_framework = true
end
1 change: 1 addition & 0 deletions appcenter-push/ios/appcenter-push.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ Pod::Spec.new do |s|
s.dependency 'AppCenterReactNativeShared'
s.dependency 'AppCenter/Push'
s.dependency 'React'
s.static_framework = true
end
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ require 'json'
package = JSON.parse(File.read(File.join(__dir__, '../package.json')))

Pod::Spec.new do |s|
s.name = package['name']
# The name is hardcoded due to a name conflict, resulting in the error 'Errno::ENOENT - No such file or directory @ rb_sysopen - appcenter.podspec.json' error.
# See https://github.com/microsoft/appcenter-sdk-react-native/issues/760
s.name = 'appcenter-core'
russelarms marked this conversation as resolved.
Show resolved Hide resolved
s.version = package['version']
s.summary = package['description']
s.license = package['license']
Expand All @@ -20,4 +22,5 @@ Pod::Spec.new do |s|
s.vendored_frameworks = 'AppCenterReactNativeShared/AppCenterReactNativeShared.framework'
s.dependency 'AppCenterReactNativeShared'
s.dependency 'React'
s.static_framework = true
end
2 changes: 1 addition & 1 deletion appcenter/react-native.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = {
dependency: {
platforms: {
ios: {
podspecPath: path.join(__dirname, 'ios', 'appcenter.podspec')
podspecPath: path.join(__dirname, 'ios', 'appcenter-core.podspec')
},
android: {
packageInstance: 'new AppCenterReactNativePackage(getApplication())'
Expand Down