Rename appcenter.podspec to appcenter-core to avoid conflicts

[russelarms]

Things to consider before you submit the PR:

• Has CHANGELOG.md been updated?
• Are tests passing locally?
• Are the files formatted correctly?
• Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Rename appcenter.podspec to appcenter-core to avoid conflicts.

Repro of the bug:
react-native init newapp && cd newapp
npm install appcenter appcenter-analytics appcenter-crashes --save-exact
cd ios && pod install && cd ..
rios
cd ios && rm -rf Pods && rm Podfile.lock && pod instal

Related PRs or issues

AB#71995
Github issue

[russelarms]

I've tested it with the TestApp and with a new sample app. In both cases, it worked fine.

[russelarms]

We have to test it with RN < 0.60, as for now, I have some issues with it. Maybe they are local.

[russelarms]

I've tested it on a sample app built with RN 0.59.9, works fine. So it's ready to be merged now.

[Jarred-Sumner]

excited for this to merge

[jaeklim]

This PR contains two items. Let's avoid combining multiple items in a PR.

[annakocheshkova]

@jaelim these two fixes only work in a bundle. One is not enough without the other.

[guperrot]

• Add a ruby comment for Rename appcenter.podspec to appcenter-core to avoid conflicts #789 (review).
• Rephrase changelog as per this thread discussion Rename appcenter.podspec to appcenter-core to avoid conflicts #789 (review).

Otherwise looks good to me.

[jaeklim]

@annakocheshkova Well, it seems to me like one name change and then one static framework change on top of name change. Am I wrong?

[guperrot]

According to me it would be counter productive to split PRs at this point but let's keep that in mind for future PRs. All files have been already reviewed anyway.

[russelarms]

• applied changelog fix
• added a comment inside the podspec file
• tested the change with both cocoapods v.1.7.5 and v1.8.4