Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP of User/manodasanw/cs win rt21 core web view2 into release/experimental #360

Merged

Conversation

bpulliam
Copy link
Collaborator

@bpulliam bpulliam commented Jul 1, 2024

Description

Bring in required changes for the WebView2 work to the release/experimental branch.

Target Release

For 1.6-experimental2

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

@Scottj1s
Copy link
Member

Scottj1s commented Jul 9, 2024

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@Scottj1s Scottj1s merged commit 5eb7e03 into release/experimental Jul 9, 2024
2 checks passed
@Scottj1s Scottj1s deleted the user/manodasanw/CsWinRT21_CoreWebView2 branch July 9, 2024 17:25
jeffstall added a commit that referenced this pull request Aug 27, 2024
* Add app WinUIDesktopAppWithIsland (#357)

* Initial checkin

* Add SceneNode Helmet

* Add readme.md

* Organize usings and remove Reunion nuget feed

* Add Lottie

* CP of User/manodasanw/cs win rt21 core web view2 into release/experimental (#360)

* Create Directory.Build.targets

* Update nuget.config

* Update Directory.Build.targets

* Update Directory.Build.targets

* Update WinUIComponentCs.csproj

* Update CsUnpackagedAppNotifications.csproj

* add CoreWebView2 nuget reference to all samples for WinAppSDK 1.6 compat

* Merge additional CoreWebView2 nuget reference fixes (#359)

* Fix up .vcxproj apps for WinUI Custom CWV2SDK support

* Patch all remaining .vcxproj for 1.6 CWV2 work

---------

Co-authored-by: DmitriyKomin <[email protected]>

---------

Co-authored-by: Manodasan Wignarajah <[email protected]>
Co-authored-by: Scott Jones <[email protected]>
Co-authored-by: DmitriyKomin <[email protected]>

* Revert "Add app WinUIDesktopAppWithIsland (#357)" (#364)

This reverts commit 2a95f69.

* Port Build 2024 Drawing samples into WASDK 1.6 exp 2 branch. (#367)

* Port DrawingIsland samples into WASDK 1.6 Exp 2

This ports the user/jeffstall/drawingisland Samples shown at Build 2024 into the release/experimental branch for WASDK 1.6 Exp 2.

* Delete DrawingIsland.cpp

Remove older sample.

* Restore the localpackages folder of nuget.config (#369)

* [SFI] Avoid download from nuget.org directly in the Agg pipeline (#371)

* Update nuget.config

* Update nuget.config

* Update to released CsWinRT versions (#373)

* Update files to WinAppSDK 1.6 Preview 2

---------

Co-authored-by: JesseCol <[email protected]>
Co-authored-by: Bob Pulliam <[email protected]>
Co-authored-by: Manodasan Wignarajah <[email protected]>
Co-authored-by: Scott Jones <[email protected]>
Co-authored-by: DmitriyKomin <[email protected]>
Co-authored-by: Jeffrey Stall <[email protected]>
Co-authored-by: alexlamtest <[email protected]>
alexlamtest pushed a commit that referenced this pull request Sep 26, 2024
…ental (#360)

* Create Directory.Build.targets

* Update nuget.config

* Update Directory.Build.targets

* Update Directory.Build.targets

* Update WinUIComponentCs.csproj

* Update CsUnpackagedAppNotifications.csproj

* add CoreWebView2 nuget reference to all samples for WinAppSDK 1.6 compat

* Merge additional CoreWebView2 nuget reference fixes (#359)

* Fix up .vcxproj apps for WinUI Custom CWV2SDK support

* Patch all remaining .vcxproj for 1.6 CWV2 work

---------

Co-authored-by: DmitriyKomin <[email protected]>

---------

Co-authored-by: Manodasan Wignarajah <[email protected]>
Co-authored-by: Scott Jones <[email protected]>
Co-authored-by: DmitriyKomin <[email protected]>
alexlamtest added a commit that referenced this pull request Sep 28, 2024
* Updated sample apps to consume 1.6-Stable

* Updated a .csproj file missed in the previous commit.

* CP of User/manodasanw/cs win rt21 core web view2 into release/experimental (#360)

* Create Directory.Build.targets

* Update nuget.config

* Update Directory.Build.targets

* Update Directory.Build.targets

* Update WinUIComponentCs.csproj

* Update CsUnpackagedAppNotifications.csproj

* add CoreWebView2 nuget reference to all samples for WinAppSDK 1.6 compat

* Merge additional CoreWebView2 nuget reference fixes (#359)

* Fix up .vcxproj apps for WinUI Custom CWV2SDK support

* Patch all remaining .vcxproj for 1.6 CWV2 work

---------

Co-authored-by: DmitriyKomin <[email protected]>

---------

Co-authored-by: Manodasan Wignarajah <[email protected]>
Co-authored-by: Scott Jones <[email protected]>
Co-authored-by: DmitriyKomin <[email protected]>

* add <WindowsSdkPackageVersion>10.0.19041.38</WindowsSdkPackageVersion> to csproj

* Updated Directory.Build.targets

* Revert "add <WindowsSdkPackageVersion>10.0.19041.38</WindowsSdkPackageVersion> to csproj"

This reverts commit f5017b4.

---------

Co-authored-by: Bob Pulliam <[email protected]>
Co-authored-by: Manodasan Wignarajah <[email protected]>
Co-authored-by: Scott Jones <[email protected]>
Co-authored-by: DmitriyKomin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants