-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app WinUIDesktopAppWithIsland #357
Merged
JesseCol
merged 5 commits into
release/1.6-experimental1
from
user/jessecol/WinUIDesktopAppWithIsland
Jun 4, 2024
Merged
Add app WinUIDesktopAppWithIsland #357
JesseCol
merged 5 commits into
release/1.6-experimental1
from
user/jessecol/WinUIDesktopAppWithIsland
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffstall
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but can you make these changes?
Samples/Islands/cs-winui-packaged/WinUIDesktopAppWithIsland/MainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
Samples/Islands/cs-winui-packaged/WinUIDesktopAppWithIsland/MainWindow.xaml.cs
Show resolved
Hide resolved
JesseCol
commented
Jun 4, 2024
Scottj1s
added a commit
that referenced
this pull request
Jul 10, 2024
jeffstall
added a commit
that referenced
this pull request
Aug 27, 2024
* Add app WinUIDesktopAppWithIsland (#357) * Initial checkin * Add SceneNode Helmet * Add readme.md * Organize usings and remove Reunion nuget feed * Add Lottie * CP of User/manodasanw/cs win rt21 core web view2 into release/experimental (#360) * Create Directory.Build.targets * Update nuget.config * Update Directory.Build.targets * Update Directory.Build.targets * Update WinUIComponentCs.csproj * Update CsUnpackagedAppNotifications.csproj * add CoreWebView2 nuget reference to all samples for WinAppSDK 1.6 compat * Merge additional CoreWebView2 nuget reference fixes (#359) * Fix up .vcxproj apps for WinUI Custom CWV2SDK support * Patch all remaining .vcxproj for 1.6 CWV2 work --------- Co-authored-by: DmitriyKomin <[email protected]> --------- Co-authored-by: Manodasan Wignarajah <[email protected]> Co-authored-by: Scott Jones <[email protected]> Co-authored-by: DmitriyKomin <[email protected]> * Revert "Add app WinUIDesktopAppWithIsland (#357)" (#364) This reverts commit 2a95f69. * Port Build 2024 Drawing samples into WASDK 1.6 exp 2 branch. (#367) * Port DrawingIsland samples into WASDK 1.6 Exp 2 This ports the user/jeffstall/drawingisland Samples shown at Build 2024 into the release/experimental branch for WASDK 1.6 Exp 2. * Delete DrawingIsland.cpp Remove older sample. * Restore the localpackages folder of nuget.config (#369) * [SFI] Avoid download from nuget.org directly in the Agg pipeline (#371) * Update nuget.config * Update nuget.config * Update to released CsWinRT versions (#373) * Update files to WinAppSDK 1.6 Preview 2 --------- Co-authored-by: JesseCol <[email protected]> Co-authored-by: Bob Pulliam <[email protected]> Co-authored-by: Manodasan Wignarajah <[email protected]> Co-authored-by: Scott Jones <[email protected]> Co-authored-by: DmitriyKomin <[email protected]> Co-authored-by: Jeffrey Stall <[email protected]> Co-authored-by: alexlamtest <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a "WinUIDesktopAppWithIsland" app that shows how to put an island in a WinUIDesktop app using experimental APIs.
Target Release
1.6 experimental1
Checklist
(Not ready for full pipeline support yet, this is just going to the release/1.6-experimental1 branch)