error TS2304: Cannot find name 'EventListenerOrEventListenerObject'

[kube]

TypeScript Version: 2.8.0-dev.20180213

Search Terms:

• Electron
• Missing EventListenerOrEventListenerObject

Problem

EventListenerOrEventListenerObject is not defined anymore in lib.d.ts, (it seems it has been renamed simply as EventListener).

This causes electron.d.ts to throw two errors during compilation:

ERROR in /Users/kube/Code/PandaNote/node_modules/electron/electron.d.ts
(6005,46): error TS2304: Cannot find name 'EventListenerOrEventListenerObject'.

ERROR in /Users/kube/Code/PandaNote/node_modules/electron/electron.d.ts
(6007,49): error TS2304: Cannot find name 'EventListenerOrEventListenerObject'.

[kube]

Just to be sure, just ran a grep -R EventListenerOrEventListenerObject *:

TypeScript 2.7 (2500+ entries)

node_modules/typescript/lib/lib.es2018.full.d.ts:    addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
node_modules/typescript/lib/lib.es2018.full.d.ts:    removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void;
node_modules/typescript/lib/lib.es2018.full.d.ts:    addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
node_modules/typescript/lib/lib.es2018.full.d.ts:    removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void;
// ...
node_modules/typescript/lib/lib.es2016.full.d.ts:declare function addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
node_modules/typescript/lib/lib.es2016.full.d.ts:declare function removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void;
node_modules/electron/electron.d.ts:    addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
node_modules/electron/electron.d.ts:    removeEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;

TypeScript 2.8 (0 entries)

node_modules/electron/electron.d.ts:    addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
node_modules/electron/electron.d.ts:    removeEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;

[mhegazy]

the type was removed in microsoft/TypeScript-DOM-lib-generator#352. I did not notice that it was used in DT already. so i think we can put the type back.