Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix few issues with EventListener and EventListenerOrEventObject #375

Merged
merged 5 commits into from
Feb 16, 2018
Merged

Fix few issues with EventListener and EventListenerOrEventObject #375

merged 5 commits into from
Feb 16, 2018

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Feb 15, 2018

#352 introduced a few issues, this PR addresses them.

Fix microsoft/TypeScript#21948
Fix microsoft/TypeScript#21922

Supersedes #374

@mhegazy
Copy link
Contributor Author

mhegazy commented Feb 15, 2018

There are too many dependencies on EventListener being an object type and not a union in our Real World code bases that i do not think it make sense to remove it. it will be a massive breaking change for very little value.
I have added special handling to EventListener as a call back interface to avoid the break.

@mhegazy mhegazy closed this Feb 16, 2018
@mhegazy mhegazy reopened this Feb 16, 2018
@saschanaz saschanaz mentioned this pull request Feb 16, 2018
Closed
@mhegazy mhegazy merged commit b60e68d into master Feb 16, 2018
@mhegazy mhegazy deleted the fix21922 branch February 16, 2018 17:39
This was referenced Feb 22, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhegazy