Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones] Browser tab freezes when trying to snap it back with other tabs already zoned (chromium-browsers) #3536

Closed
ion-elgreco opened this issue May 22, 2020 · 45 comments
Assignees
Labels
FancyZones-Dragging&UI FancyZone dragging / interaction issue Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@ion-elgreco
Copy link

Environment

Windows build number: Microsoft Windows [Version 10.0.18363.836]
PowerToys version: v0.18.1
PowerToy module for which you are reporting the bug (if applicable): Fancyzones

Steps to reproduce

  1. Install brave/chrome (chromium-based) browser
  2. Open up two tabs in separate windows.
  3. Turn on fancyzones
  4. Drag one tab into the other, so that your browser window has two tabs. Try to do this a couple of times and you will see the tab sometime freezes and becomes unresponsive, or turns black and becomes unresponsive.

Expected behavior

Tab has to snap into the browser

Actual behavior

Tab is crashing and closes instantly when you snap it in. This doesn't happen when fancyzones is off.

Screenshots

@enricogior
Copy link
Contributor

Hi @ion-elgreco
I was able to reproduce it with 0.18.0, but I can't reproduce it with 0.18.1.
I tested Edge Chromium, Chrome and Brave and they all work as expected.
Is there anything that you changed in the FZ settings compared to the #3504 (comment) ?

@enricogior enricogior added the Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. label May 22, 2020
@ion-elgreco
Copy link
Author

Hi @ion-elgreco
I was able to reproduce it with 0.18.0, but I can't reproduce it with 0.18.1.
I tested Edge Chromium, Chrome and Brave and they all work as expected.
Is there anything that you changed in the FZ settings compared to the #3504 (comment) ?

No, still the same settings. I also used Chrome and chromium version of edge. They all have the same issue.

On the old version of edge (before chromium, I don't have this issue).

@enricogior
Copy link
Contributor

Can you verify in the PowerToys General Settings that you are running 0.18.1?

@ion-elgreco
Copy link
Author

Can you verify in the PowerToys General Settings that you are running 0.18.1?

Annotation 2020-05-22 202926

@enricogior
Copy link
Contributor

Does it happen all the times?

@ion-elgreco
Copy link
Author

Does it happen all the times?

Maybe 9 out of 10. If I move my tab real fast, imagine this: You quickly throw your tab onto your browser, then it works better.

@enricogior
Copy link
Contributor

If you turn off the transparency for the dragged window does it make any difference?

@enricogior enricogior removed the Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. label May 22, 2020
@ion-elgreco
Copy link
Author

ion-elgreco commented May 22, 2020

If you turn off the transparency for the dragged window does it make any difference?

Not really, sometimes works, but also sometimes doesn't work. However it seems to occur less with transparency off.

Edit:
Turning transparency on again, and then a drag instantly freezes window when you tab it.

@enricogior
Copy link
Contributor

OK thanks,

@enricogior enricogior added the FancyZones-Dragging&UI FancyZone dragging / interaction issue label May 22, 2020
@ion-elgreco
Copy link
Author

OK thanks,

Turning transparency off helps, but it still causes to occasionally crash a window (closing) when tabbing or freezes the window when tabbing.

@pokemav
Copy link

pokemav commented Jul 17, 2020

this problem is still present as of v.19.2. I move tabs alot and have been struggling with this problem since version .18 I think.
Hope this is a bug worth working on.

@ion-elgreco
Copy link
Author

How is this still not fixed?

@enricogior
Copy link
Contributor

@pokemav @ion-elgreco
can you still reproduce it with 0.21.1? https://github.com/microsoft/PowerToys/releases/tag/v0.21.1

@enricogior enricogior added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Community Feedback We need additional help with how something should act / look labels Sep 9, 2020
@ion-elgreco
Copy link
Author

@pokemav @ion-elgreco
can you still reproduce it with 0.21.1? https://github.com/microsoft/PowerToys/releases/tag/v0.21.1

Yeah, still the same issue.

@enricogior enricogior removed the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 30, 2020
@enricogior
Copy link
Contributor

Confirmed: this commit broke the fix 3d36779#diff-ff7794bdc47c8ebd8c1cecabe2f532fc
Sorry about that.

@ion-elgreco
Copy link
Author

Confirmed: this commit broke the fix 3d36779#diff-ff7794bdc47c8ebd8c1cecabe2f532fc
Sorry about that.

No problem, when can we expect to have the fix back as an update? It's very difficult to use powertoys at the moment when I cant snap a window back in its place :(.

@enricogior
Copy link
Contributor

@ion-elgreco
if we release an hotfix for 0.23.0, this will be included. Otherwise if we don't release an hotfix, and if it's acceptable for you to installed an unsigned build, I can provide a private build with the fix.

@ion-elgreco
Copy link
Author

@ion-elgreco
if we release an hotfix for 0.23.0, this will be included. Otherwise if we don't release an hotfix, and if it's acceptable for you to installed an unsigned build, I can provide a private build with the fix.

In case there isn't a hotfix, I am completely fine with an unsigned build :)

@stefansjfw
Copy link
Collaborator

I fixed it. I broke it ( sorry :( ). I fixed it again :) I hope it will get to @ion-elgreco this time :)

@ion-elgreco
Copy link
Author

I fixed it. I broke it ( sorry :( ). I fixed it again :) I hope it will get to @ion-elgreco this time :)

Haha made me laugh 💯 Thanks for the work guys, much appreciated!

@enricogior
Copy link
Contributor

Fan fact: the first fix worked because two bugs were cancelling each other, then we made a commit that unintentionally fixed one of the two bugs exposing the second one... true story :)

@enricogior enricogior added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Oct 1, 2020
@enricogior
Copy link
Contributor

@ion-elgreco
it will be released in a hotfix release (probably early next week).

@enricogior enricogior added the Hot Fix Items we will product an out-of-band release for label Oct 1, 2020
@ion-elgreco
Copy link
Author

@ion-elgreco
it will be released in a hotfix release (probably early next week).

Amazing :) Thank you!

@ion-elgreco
Copy link
Author

Thanks for the fix guys! 👍 🥇

@crutkas
Copy link
Member

crutkas commented Oct 9, 2020

Fixed in https://github.com/microsoft/PowerToys/releases/tag/v0.23.2

@crutkas crutkas closed this as completed Oct 9, 2020
@alexmattelon
Copy link

Hey,

Unfortunately I still have the issue with v0.33.1

@enricogior
Copy link
Contributor

@alexmattelon
can you post a screenshot, or even better a screen capture, of the frozen tab?

@alexmattelon
Copy link

@alexmattelon
can you post a screenshot, or even better a screen capture, of the frozen tab?

I've been trying to replicate for the last week, and can't get it to bug anymore!

@alexmattelon
Copy link

It finally happened, as you can see in the video https://drive.google.com/file/d/1jnFN36ZjvC7rtTPEs3h-61XsIfHoou-Q/view?usp=sharing the tab is stuck, you can't click on anything or close it.

This happened when I tried moving tabs from one window to another, it worked for the first three, then when I tried to move the last one from this window to another window, it froze.
From what I remember, it always happen on the last tab.

@top1105
Copy link

top1105 commented Mar 29, 2021

Experiencing this issue as well on v0.33.1, about 1-3 times a day. Usually when I try to drag a Chrome tab into another window. Happens randomly and hard to replicate.

@louga31
Copy link

louga31 commented Oct 17, 2021

I still have the issue in v0.47.1, this is getting ridiculous

@franky920920
Copy link
Contributor

franky920920 commented Oct 18, 2021

@louga31 , please raise a new issue for v0.47.1 and mention this issue #3536. Thank you!

@crutkas
Copy link
Member

crutkas commented Oct 18, 2021

@louga31 like frank mentioned, please create a new issue and providing a easy to reproduce flow to recreate. More info the better.

Stuff is hard due to all the permutations :)

@louga31
Copy link

louga31 commented Oct 19, 2021

@franky920920 @crutkas Created a new issue with a reproduction method that always works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FancyZones-Dragging&UI FancyZone dragging / interaction issue Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

9 participants