Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser tab freezes when trying to snap it back with other tabs already zoned #13911

Closed
1 task done
louga31 opened this issue Oct 19, 2021 · 30 comments
Closed
1 task done
Assignees
Labels
Area-App Compat Issues revolving around application compatibility across PowerToys Issue-Bug Something isn't working Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Product-FancyZones Refers to the FancyZones PowerToy

Comments

@louga31
Copy link

louga31 commented Oct 19, 2021

This is a continuation of this issue #3536

Microsoft PowerToys version

0.47.1

Running as admin

  • Yes

Area(s) with issue?

FancyZones

Steps to reproduce

This reproduction method works on 100% of tries for me (I can make a video if this helps).

  1. Install Google Chrome
  2. Make sure FancyZones is on
  3. Open up two tabs in the same window
  4. Zone this window using FancyZones
  5. Take one tab out, and zone the newly created window in the same zone as the old one (on top of it).
  6. Take the tab and try to snap it into the window under it
  7. It should instantly become white and unresponsive

Another way of reproducing the issue in case the one before didn't worked for you:

  1. Open up two tabs in separate windows.
  2. Make sure both tabs are zoned in different zones
  3. Drag one tab into the other
  4. Draw one tab into the other to merge them into one window. Try to do this a couple of times, and you should see the tab freezes and becomes unresponsive, or turns black.

It seems to make it easier to reproduce when the target window have many tabs in it.

✔️ Expected Behavior

Tab should snap in without crashing

❌ Actual Behavior

Tab is crashing and becomes unresponsive when you snap it in.
It can happen both when you take the tab out of the zone or when actually snapping it into the other window.
Sometimes the tab simply disappear when taking it and can only be closed through the task manager.
This doesn't happen when FancyZones is off.
image

Other Software

Google Chrome 94.0.4606.81 (Official build) (64 bits)

@louga31 louga31 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 19, 2021
@ion-elgreco
Copy link

Does this happen with Edge as well?

@franky920920 franky920920 added FancyZones-App Compat Product-FancyZones Refers to the FancyZones PowerToy labels Oct 19, 2021
@louga31
Copy link
Author

louga31 commented Oct 19, 2021

@ion-elgreco

Does this happen with Edge as well?

Just tested and yes, but instead of becoming white, it freezes the content
On this image, none of the buttons of the front tab works event the minimize, maximize and close (I can still move the window but nothing works in it)
image

@franky920920
Copy link
Contributor

Failed to reproduce this.
Could you attach a full bug report file?
Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!
image


cc: @stefansjfw Any ideas?

@franky920920 franky920920 added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 20, 2021
@stefansjfw
Copy link
Collaborator

cc: @stefansjfw Any ideas?

I can't reproduce this on Win 10. Let me try Win 11, it might be something Win 11 specific

@franky920920
Copy link
Contributor

I can't reproduce this on Win 10. Let me try Win 11, it might be something Win 11 specific

I can't reproduce this on Windows 11.

@Aaron-Junker
Copy link
Collaborator

I can't reproduce it in Windows 11. @louga31 Is it possible to attach a video screen recording of it?

@Aaron-Junker Aaron-Junker added the Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. label Oct 20, 2021
@louga31
Copy link
Author

louga31 commented Oct 20, 2021

@franky920920 Here is the report
PowerToysReport_2021-10-20-11-32-03.zip
@Aaron-Junker Here is the video of the bug. I can reproduce it on every try with this method

FancyZones.mp4

@ghost ghost added Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Oct 20, 2021
@franky920920
Copy link
Contributor

franky920920 commented Oct 20, 2021

@louga31 I'm still failing to reproduce this even going step-by-step in the video.
Cloud you check what is your Edge version? Check this at edge://version/.

@franky920920 franky920920 added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Team-Response An issue author responded so the team needs to follow up labels Oct 20, 2021
@louga31
Copy link
Author

louga31 commented Oct 20, 2021

Here is my Edge version infos:

Microsoft Edge | 94.0.992.50 (Official build) (64-bit)
Revision | 80a49a71b4e2d00a1499ea10b608fe26bb6f41e7
Operating system | Windows 11 Version 21H2 (Build 22000.258)

@ghost ghost added Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Oct 20, 2021
@SeraphimaZykova SeraphimaZykova self-assigned this Oct 28, 2021
@harrison-munitz
Copy link

I am also able to reproduce this with 100% consistency on v0.23.2 which I was on before and, after updating to v0.51.1, still almost 100%

As far as minimum repreducible steps:

  1. Open a tab in any chromium browser (i've tested chrome + edge successfully, IE did not have the same issue)
  2. Assign that tab's window to a fancy zone
  3. Open a 2nd window (or have it open from the start). It's position does not matter at all, zone or not
  4. Clicking and dragging on the original tab header to move the tab itself (not the window), drag it on top of the tabs of the 2nd window. You don't even have to let go of the tab, just drag it to the spot that you would drop it on.
  5. The dragged tab will freeze, sometimes it will completely crash and disappear instead.

The tab that you drag has to be the only tab in the window, dragging a tab from a window with multiple tabs will not cause it to crash. Dragging all of the tabs from a window however (by selecting multiple with shift+click) will cause the crash. As long as you are dragging the entire window (via tabs) and not creating a new window by dragging the tab, it works.

When the window freezes (and doesn't just crash) it is completely unresponsive in every except that it can be moved. Attempting to interact with it does nothing. Trying to close the window via the X button, or via the taskbar does nothing. I have to resort to either the chrome or windows task manager to close the tab.

I'd be happy to provide any other info / screenshots/ videos or even a video call to show it off. I highly value fancy zones and this bug is very annoying.

@harrison-munitz
Copy link

I went ahead and made a video showing the issue, hopefully a bit more clearly than the other video provided. I made sure to enable the PowerToys mouse utility for clarity. In the video are tabs both disappearing and freezing, not being able to close the frozen tab except with task manager, and showing that it still crashes when using multiple tabs.

The video is here: https://imgur.com/a/54kWTmH

@SeraphimaZykova
Copy link
Collaborator

@harrison-munitz thank you very much for the clarification. I was able to reproduce the problem using the steps you described, but it happened just once for me. Can you please attach a bug report to help us investigate it?

@SeraphimaZykova
Copy link
Collaborator

/bugreport

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Dec 16, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

Hi there!

We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here? You right click on our system tray icon and just go to report bug. Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!
Report Bug

@harrison-munitz
Copy link

I took this log immediately after booting up my computer and recreating the bug once. Hopefully it should be as simple as possible to see when the issue occured: PowerToysReport_2021-12-16-12-41-02.zip

Also, I went and tested a few more configurations of settings to see if the bug still happened. Disabling PowerToys and using Windows default edge/corner snapping does not trigger the bug, but changing my settings for how FancyZones was activated did have an effect! I now believe it has something to do with the overlay that appears when you move the zones around:

  • I usually use the "hold shift to activate zones" option, where the overlay won't activate until I'm holding shift while dragging a window. This causes the crash 100% of the time.
  • If I disable that option, the overlay will show up every time when I drag a window. This never crashes while merging tabs.
  • If I enable the "Use a non-primary mouse button to toggle" option, then I can at will enable and disable the overlay. 100% consistently, merging tabs with the overlay on screen does not crash, but if I disable the overlay while I'm dragging the tab, but before it collides with the other window, it will crash.

I'll try to take another video to better demonstrate what I'm saying. But basically, if the overlay isn't on screen when merging the tab, it will do the crash.

I reckon this is why you were having so much trouble recreating it.

@crutkas crutkas added Area-App Compat Issues revolving around application compatibility across PowerToys and removed FancyZones-App Compat labels Jan 7, 2022
@ken-ceci
Copy link

I consistently encounter this issue. I'll have many instances of Edge open each snapped to a fancy zone. Multiple tabs open in each instance. When I drag any tab to a different instance, dragging hangs up for about 10 seconds with the desktop in the fancy zone drag state (everything greyed a bit). Otherwise really loving and needing the fancy zones feature.

@SeraphimaZykova
Copy link
Collaborator

New PowerToys release v0.56. will be out soon. Could you check if the issue is still there when you update to v0.56 and if yes, post the new bug report here?

Thanks in advance!

@SeraphimaZykova SeraphimaZykova added revisit-0.56 and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Feb 28, 2022
@harrison-munitz
Copy link

Do you have any idea when that update will be live? Or is there a beta branch that I could download now?

@franky920920
Copy link
Contributor

@harrison-munitz 0.56 is out now! Head over to https://aka.ms/installpowertoys to try it out! /needinfo

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 28, 2022
@harrison-munitz
Copy link

The problem seems to be happening exactly as before. I've attached a bug report below.
Am I supposed to do anything with my settings to fix it? I saw some changes to popup windows in the patch notes but I haven't enabled the setting.

PowerToysReport_2022-02-28-19-24-56.zip

@louga31
Copy link
Author

louga31 commented Mar 4, 2022

I can confirm the issue still persist on 0.56.1

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 4, 2022
@Jay-o-Way
Copy link
Collaborator

Is this still an issue with the latest version? /needinfo (can't reproduce myself)

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Nov 22, 2022
@ken-ceci
Copy link

ken-ceci commented Nov 22, 2022 via email

@louga31
Copy link
Author

louga31 commented Nov 24, 2022

I can still reproduce it 100% of the time using @harrison-munitz's method, but now it always makes the tab completely crash and disappear, no more frozen tab. I can do another video recording of it if this can help you recreate it.

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 24, 2022
@TheJoeFin
Copy link
Collaborator

does this issue still happen with v0.73.0? /needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Sep 16, 2023
@ion-elgreco
Copy link

does this issue still happen with v0.73.0? /needinfo

No for me not anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-App Compat Issues revolving around application compatibility across PowerToys Issue-Bug Something isn't working Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Product-FancyZones Refers to the FancyZones PowerToy
Projects
None yet
Development

No branches or pull requests